Issue 366653002: Specify the name of tool for creating a makefile.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 366653002: Specify the name of tool for creating a makefile. (Closed)

Created:
6 years, 5 months ago by scroggo

Modified:
6 years, 5 months ago

Reviewers:
mtklein

CC:
reviews_skia.org

Base URL:
https://skia.googlesource.com/skia.git@master

Project:
skia

Visibility:
Public.

More Reviews

Description

Specify the name of tool for creating a makefile. When generating tool Android.mks from gyp files, specify the name of the target needed. This fixes a bug where nanobench was being added to the same makefile as bench, which would not compile. TODO: Make gyp_to_android more general, so that it handles this case better. See http://skbug.com/2709 Committed: https://skia.googlesource.com/skia/+/950f89dd20325bf4dfce588d9f64644040787a06

Patch Set 1 #

Created: 6 years, 5 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+10 lines, -4 lines)			Patch
	M	platform_tools/android/bin/gyp_to_android.py	View		4 chunks	+7 lines, -3 lines	0 comments	Download
	M	platform_tools/android/gyp_gen/tool_makefile_writer.py	View		3 chunks	+3 lines, -1 line	0 comments	Download

Messages

Total messages: 5 (0 generated)

Expand Messages | Collapse Messages

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://skia-tree-status.appspot.com/cq/scroggo@google.com/366653002/1

6 years, 5 months ago (2014-07-01 14:47:59 UTC) #4

commit-bot: I haz the power

6 years, 5 months ago (2014-07-01 15:02:33 UTC) #5

Message was sent while issue was closed.

Change committed as 950f89dd20325bf4dfce588d9f64644040787a06

Expand Messages | Collapse Messages