Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(415)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 366633002: DevTools: Move jsdifflib to "sources", extract "toolbox" module (Closed)

Created:
6 years, 5 months ago by apavlov
Modified:
6 years, 5 months ago
Reviewers:
aandrey, vsevik, dgozman
CC:
blink-reviews, caseq+blink_chromium.org, loislo+blink_chromium.org, eustas+blink_chromium.org, malch+blink_chromium.org, yurys+blink_chromium.org, lushnikov+blink_chromium.org, vsevik+blink_chromium.org, pfeldman+blink_chromium.org, paulirish+reviews_chromium.org, apavlov+blink_chromium.org, devtools-reviews_chromium.org, sergeyv+blink_chromium.org, aandrey+blink_chromium.org
Project:
blink
Visibility:
Public.

Description

DevTools: Move jsdifflib to "sources", extract "toolbox" module This patch is aimed at reducing the "devtools_core_base_files" scope, which essentially contains unclassified JS. R=vsevik@chromium.org, aandrey, vsevik Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=177394

Patch Set 1 #

Patch Set 2 : #

Patch Set 3 : #

Total comments: 5

Patch Set 4 : Address comment #

Patch Set 5 : Remove trailing whitespace in jsdifflib.js #

Unified diffs Side-by-side diffs Delta from patch set Stats (+26 lines, -1688 lines) Patch
M Source/devtools/BUILD.gn View 1 2 1 chunk +2 lines, -1 line 0 comments Download
M Source/devtools/devtools.gyp View 1 2 1 chunk +6 lines, -0 lines 0 comments Download
M Source/devtools/devtools.gypi View 1 2 3 5 chunks +7 lines, -4 lines 0 comments Download
D Source/devtools/front_end/MediaQueryInspector.js View 1 chunk +0 lines, -528 lines 0 comments Download
D Source/devtools/front_end/ResponsiveDesignView.js View 1 chunk +0 lines, -612 lines 0 comments Download
D Source/devtools/front_end/components/InspectedPagePlaceholder.js View 1 2 1 chunk +0 lines, -123 lines 0 comments Download
M Source/devtools/front_end/inspector.html View 1 2 3 3 chunks +3 lines, -4 lines 0 comments Download
D Source/devtools/front_end/jsdifflib.js View 1 chunk +0 lines, -409 lines 0 comments Download
M Source/devtools/front_end/sources/SourcesPanel.js View 1 chunk +1 line, -0 lines 0 comments Download
A + Source/devtools/front_end/sources/jsdifflib.js View 1 2 3 4 2 chunks +3 lines, -3 lines 0 comments Download
A + Source/devtools/front_end/toolbox/InspectedPagePlaceholder.js View 1 2 3 0 chunks +-1 lines, --1 lines 0 comments Download
A + Source/devtools/front_end/toolbox/MediaQueryInspector.js View 1 2 0 chunks +-1 lines, --1 lines 0 comments Download
A + Source/devtools/front_end/toolbox/ResponsiveDesignView.js View 1 2 0 chunks +-1 lines, --1 lines 0 comments Download
M Source/devtools/scripts/frontend_modules.json View 1 2 3 3 chunks +7 lines, -7 lines 0 comments Download

Messages

Total messages: 10 (0 generated)
apavlov
6 years, 5 months ago (2014-07-01 13:50:27 UTC) #1
vsevik
lgtm https://chromiumcodereview.appspot.com/366633002/diff/60001/Source/devtools/devtools.gypi File Source/devtools/devtools.gypi (right): https://chromiumcodereview.appspot.com/366633002/diff/60001/Source/devtools/devtools.gypi#newcode159 Source/devtools/devtools.gypi:159: 'front_end/ui/InspectedPagePlaceholder.js', Can we move it to toolbox? https://chromiumcodereview.appspot.com/366633002/diff/60001/Source/devtools/scripts/frontend_modules.json ...
6 years, 5 months ago (2014-07-02 13:21:30 UTC) #2
dgozman
https://chromiumcodereview.appspot.com/366633002/diff/60001/Source/devtools/scripts/frontend_modules.json File Source/devtools/scripts/frontend_modules.json (right): https://chromiumcodereview.appspot.com/366633002/diff/60001/Source/devtools/scripts/frontend_modules.json#newcode179 Source/devtools/scripts/frontend_modules.json:179: "dependencies": ["ui", "sdk"], On 2014/07/02 13:21:29, vsevik wrote: > ...
6 years, 5 months ago (2014-07-02 13:25:09 UTC) #3
apavlov
https://codereview.chromium.org/366633002/diff/60001/Source/devtools/devtools.gypi File Source/devtools/devtools.gypi (right): https://codereview.chromium.org/366633002/diff/60001/Source/devtools/devtools.gypi#newcode159 Source/devtools/devtools.gypi:159: 'front_end/ui/InspectedPagePlaceholder.js', On 2014/07/02 13:21:29, vsevik wrote: > Can we ...
6 years, 5 months ago (2014-07-02 13:38:58 UTC) #4
apavlov
The CQ bit was checked by apavlov@chromium.org
6 years, 5 months ago (2014-07-02 13:39:02 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/apavlov@chromium.org/366633002/80001
6 years, 5 months ago (2014-07-02 13:39:20 UTC) #6
commit-bot: I haz the power
FYI, CQ is re-trying this CL (attempt #1). The failing builders are: blink_presubmit on tryserver.blink ...
6 years, 5 months ago (2014-07-02 14:45:10 UTC) #7
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 5 months ago (2014-07-02 14:47:49 UTC) #8
commit-bot: I haz the power
Try jobs failed on following builders: blink_presubmit on tryserver.blink (http://build.chromium.org/p/tryserver.blink/builders/blink_presubmit/builds/9156)
6 years, 5 months ago (2014-07-02 14:47:50 UTC) #9
apavlov
6 years, 5 months ago (2014-07-02 14:56:17 UTC) #10
Message was sent while issue was closed. 
Committed patchset #5 manually as r177394 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698