Mac VideoCapture: return empty GetModel() for non-USB non-built-in cameras.

media/video/capture/mac/video_capture_device_mac.h

Index: media/video/capture/mac/video_capture_device_mac.h
diff --git a/media/video/capture/mac/video_capture_device_mac.h b/media/video/capture/mac/video_capture_device_mac.h
index 36dc015e373f6f87a932febc669e14afff47599c..e255c840b37b577f311826b7eabcff446cf7de11 100644
--- a/media/video/capture/mac/video_capture_device_mac.h
+++ b/media/video/capture/mac/video_capture_device_mac.h
@@ -10,6 +10,7 @@
 #ifndef MEDIA_VIDEO_CAPTURE_MAC_VIDEO_CAPTURE_DEVICE_MAC_H_
 #define MEDIA_VIDEO_CAPTURE_MAC_VIDEO_CAPTURE_DEVICE_MAC_H_
 
+#import <Foundation/Foundation.h>

[Robert Sesek, 2014/07/01 14:16:07]

nit: blank line after

[mcasas, 2014/07/01 16:06:10]

Done.

 #include <string>
 
 #include "base/compiler_specific.h"
@@ -24,6 +25,26 @@ namespace base {
 class SingleThreadTaskRunner;
 }
 
+MEDIA_EXPORT
+@interface DeviceNameAndTransportType : NSObject {

[Robert Sesek, 2014/07/01 14:16:07]

Class needs a comment about its purpose.

[mcasas, 2014/07/01 16:06:10]

Done.

+  enum {
+    // Unknown transport type, addition to the kIOAudioDeviceTransportType*
+    // family for QTKit devices where this attribute isn't published.
+    kIOAudioDeviceTransportTypeUnknown = 'unkn'
+  };

[Robert Sesek, 2014/07/01 14:16:07]

nit: blank line after, and I"d maybe move this enum out of @interface – that's
pretty atypical.

[mcasas, 2014/07/01 16:06:10]

Done.

+ @private
+  NSString* deviceName_;

[Robert Sesek, 2014/07/01 14:16:07]

This should be strongly referenced, otherwise who owns the memory?

[mcasas, 2014/07/01 16:06:10]

Done.

+  // The transport type of the device (USB, PCI, etc), values are defined in
+  // <IOKit/audio/IOAudioTypes.h> as kIOAudioDeviceTransportType*.
+  int32_t transportType_;
+}
+
+- (id)initWithName:(NSString*)name transportType:(int32_t)transportType;
+
+- (NSString*)deviceName;
+- (int32_t)transportType;
+@end
+
 namespace media {
 
 // Called by VideoCaptureManager to open, close and start, stop Mac video