Issue 366543004: Make 1.5x DPI text render crisply.

Issue 366543004: Make 1.5x DPI text render crisply. (Closed)

Created:
6 years, 5 months ago by calamity

Modified:
6 years, 5 months ago

Reviewers:
sky

CC:
chromium-reviews, yusukes+watch_chromium.org, yukishiino+watch_chromium.org, jam, penghuang+watch_chromium.org, sievers+watch_chromium.org, jbauman+watch_chromium.org, nona+watch_chromium.org, darin-cc_chromium.org, kalyank, piman+watch_chromium.org, danakj+watch_chromium.org, James Su, miu+watch_chromium.org, chrome-apps-syd-reviews_chromium.org

Base URL:
https://chromium.googlesource.com/chromium/src.git@master

Visibility:
Public.

More Reviews

Description

Make 1.5x DPI text render crisply. This CL fixes an issue where the text would render blurrily on 1.5x DPI screens. This was caused by WebContentsView::OnBoundsChanged() not getting called because the origin is no longer changed when switching the active tab as it is always inside the clipping window. This is fixed by calling SnapToPhysicalPixelBoundary() when the clipping window gets a new WebContents set. BUG=388908 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=282583

Patch Set 1 : #

Total comments: 2

Patch Set 2 : reorder methods #

Created: 6 years, 5 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+82 lines, -78 lines)			Patch
M	content/browser/renderer_host/render_widget_host_view_aura.h	View		2 chunks	+2 lines, -2 lines	0 comments	Download
M	content/browser/renderer_host/render_widget_host_view_aura.cc	View	1	2 chunks	+72 lines, -72 lines	0 comments	Download
M	content/browser/web_contents/web_contents_view_aura.cc	View		2 chunks	+8 lines, -4 lines	0 comments	Download

Messages

Total messages: 6 (0 generated)

Expand Messages | Collapse Messages

sky

LGTM https://codereview.chromium.org/366543004/diff/40001/content/browser/renderer_host/render_widget_host_view_aura.h File content/browser/renderer_host/render_widget_host_view_aura.h (right): https://codereview.chromium.org/366543004/diff/40001/content/browser/renderer_host/render_widget_host_view_aura.h#newcode339 content/browser/renderer_host/render_widget_host_view_aura.h:339: void SnapToPhysicalPixelBoundary(); Move implementation to match new position.

6 years, 5 months ago (2014-07-10 16:30:45 UTC) #2

calamity

https://codereview.chromium.org/366543004/diff/40001/content/browser/renderer_host/render_widget_host_view_aura.h File content/browser/renderer_host/render_widget_host_view_aura.h (right): https://codereview.chromium.org/366543004/diff/40001/content/browser/renderer_host/render_widget_host_view_aura.h#newcode339 content/browser/renderer_host/render_widget_host_view_aura.h:339: void SnapToPhysicalPixelBoundary(); On 2014/07/10 16:30:45, sky wrote: > Move ...

6 years, 5 months ago (2014-07-11 03:24:23 UTC) #3

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/calamity@chromium.org/366543004/60001

6 years, 5 months ago (2014-07-11 03:25:22 UTC) #5

Message was sent while issue was closed.

Change committed as 282583

Expand Messages | Collapse Messages