Stop depending on chrome/browser/rlz/rlz.h from TemplateURLService

Stop depending on chrome/browser/rlz/rlz.h from TemplateURLService

TemplateURLServiceFactory is responsible to inject a Closure.

BUG=381572
TEST=build a RLZ enabled binary
TBR=battre@chromium.org for profile_resetter_unittest.cc

Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=280974

[Peter Kasting, 2014-07-01 18:19:08]

https://codereview.chromium.org/366523002/diff/1/chrome/browser/search_engine...
File chrome/browser/search_engines/template_url_service.h (right):

https://codereview.chromium.org/366523002/diff/1/chrome/browser/search_engine...
chrome/browser/search_engines/template_url_service.h:691: base::Closure
dsp_changed_to_google_event_recorder_;
Let's just call this |dsp_change_callback_| and rely on comments to make it
clear that it's only called on changing the DSP to Google.  That makes the name
a bit more comprehensible.

https://codereview.chromium.org/366523002/diff/1/chrome/browser/search_engine...
File chrome/browser/search_engines/template_url_service_factory.cc (right):

https://codereview.chromium.org/366523002/diff/1/chrome/browser/search_engine...
chrome/browser/search_engines/template_url_service_factory.cc:42:
service->set_dsp_changed_to_google_event_recorder(
If we're going to call this at the same time we construct the
TemplateURLService, we should pass this as a constructor arg instead of having
an accessor function to set it.

[hashimoto, 2014-07-01 23:24:49]

https://codereview.chromium.org/366523002/diff/1/chrome/browser/search_engine...
File chrome/browser/search_engines/template_url_service.h (right):

https://codereview.chromium.org/366523002/diff/1/chrome/browser/search_engine...
chrome/browser/search_engines/template_url_service.h:691: base::Closure
dsp_changed_to_google_event_recorder_;
On 2014/07/01 18:19:08, Peter Kasting wrote:
> Let's just call this |dsp_change_callback_| and rely on comments to make it
> clear that it's only called on changing the DSP to Google.  That makes the
name
> a bit more comprehensible.

Done.

https://codereview.chromium.org/366523002/diff/1/chrome/browser/search_engine...
File chrome/browser/search_engines/template_url_service_factory.cc (right):

https://codereview.chromium.org/366523002/diff/1/chrome/browser/search_engine...
chrome/browser/search_engines/template_url_service_factory.cc:42:
service->set_dsp_changed_to_google_event_recorder(
On 2014/07/01 18:19:08, Peter Kasting wrote:
> If we're going to call this at the same time we construct the
> TemplateURLService, we should pass this as a constructor arg instead of having
> an accessor function to set it.

Done.

[Peter Kasting, 2014-07-02 01:10:53]

LGTM

https://codereview.chromium.org/366523002/diff/20001/chrome/browser/search_en...
File chrome/browser/search_engines/template_url_service.h (right):

https://codereview.chromium.org/366523002/diff/20001/chrome/browser/search_en...
chrome/browser/search_engines/template_url_service.h:685: // This closure is run
when the default search provider is set to google.
Nit: Google

[hashimoto, 2014-07-02 03:10:33]

https://codereview.chromium.org/366523002/diff/20001/chrome/browser/search_en...
File chrome/browser/search_engines/template_url_service.h (right):

https://codereview.chromium.org/366523002/diff/20001/chrome/browser/search_en...
chrome/browser/search_engines/template_url_service.h:685: // This closure is run
when the default search provider is set to google.
On 2014/07/02 01:10:53, Peter Kasting wrote:
> Nit: Google

Done.

[hashimoto, 2014-07-02 03:22:02]

The CQ bit was checked by hashimoto@chromium.org

[commit-bot: I haz the power, 2014-07-02 03:22:53]

CQ is trying da patch. Follow status at
 https://chromium-status.appspot.com/cq/hashimoto@chromium.org/366523002/60001

[commit-bot: I haz the power, 2014-07-02 05:04:31]

FYI, CQ is re-trying this CL (attempt #1).
The failing builders are:
  chromium_presubmit on tryserver.chromium
(http://build.chromium.org/p/tryserver.chromium/builders/chromium_presubmit/bu...)

[hashimoto, 2014-07-02 05:06:37]

TBRing battre@chromium.org for profile_resetter_unittest.cc

[hashimoto, 2014-07-02 05:06:41]

The CQ bit was unchecked by hashimoto@chromium.org

[hashimoto, 2014-07-02 05:06:43]

The CQ bit was checked by hashimoto@chromium.org

[commit-bot: I haz the power, 2014-07-02 05:07:08]

CQ is trying da patch. Follow status at
 https://chromium-status.appspot.com/cq/hashimoto@chromium.org/366523002/60001

[battre, 2014-07-02 06:56:57]

profile_resetter_unittest.cc LGTM

[commit-bot: I haz the power, 2014-07-02 07:40:26]

Change committed as 280974