sdk/lib/_internal/pub/lib/src/utils.dart - Issue 366513002: Print the most recent available version of packages being upgraded.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: sdk/lib/_internal/pub/lib/src/utils.dart

Issue 366513002: Print the most recent available version of packages being upgraded. (Closed) Base URL: https://dart.googlecode.com/svn/branches/bleeding_edge/dart

Patch Set: code review Created 6 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « sdk/lib/_internal/pub/lib/src/solver/solve_report.dart ('k') | sdk/lib/_internal/pub/test/upgrade/report/does_not_show_newer_versions_for_locked_packages_test.dart » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: sdk/lib/_internal/pub/lib/src/utils.dart

diff --git a/sdk/lib/_internal/pub/lib/src/utils.dart b/sdk/lib/_internal/pub/lib/src/utils.dart

index eaf34f7c64838958b789e7f1803767366c2b6d03..b3d585db92a97b0ebc12d379dd741e25fa0fe382 100644

--- a/sdk/lib/_internal/pub/lib/src/utils.dart

+++ b/sdk/lib/_internal/pub/lib/src/utils.dart

@@ -359,9 +359,14 @@ Set<String> createDirectoryFilter(Iterable<String> dirs) {

}).toSet();

}

-/// Returns the maximum value in [iter].

-int maxAll(Iterable<int> iter) =>

- iter.reduce((max, element) => element > max ? element : max);

+/// Returns the maximum value in [iter] by [compare].

+///

+/// [compare] defaults to [Comparable.compare].

+maxAll(Iterable iter, [int compare(element1, element2)]) {

+ if (compare == null) compare = Comparable.compare;

+ return iter.reduce((max, element) =>

+ compare(element, max) > 0 ? element : max);

/// Replace each instance of [matcher] in [source] with the return value of

/// [fn].