Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(764)

Issue 366473002: Remove unused exposed APIs for WebRuntimeFeatures (Closed)

Created:
6 years, 5 months ago by lgombos
Modified:
6 years, 5 months ago
CC:
abarth-chromium, blink-reviews, dglazkov+blink, jamesr
Base URL:
https://chromium.googlesource.com/chromium/blink.git@master
Project:
blink
Visibility:
Public.

Description

These blink API functions are not used, we should remove them. Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=177269

Patch Set 1 #

Total comments: 1

Patch Set 2 : Keep enableLaxMixedContentChecking #

Unified diffs Side-by-side diffs Delta from patch set Stats (+0 lines, -21 lines) Patch
M Source/web/WebRuntimeFeatures.cpp View 1 3 chunks +0 lines, -15 lines 0 comments Download
M public/web/WebRuntimeFeatures.h View 1 3 chunks +0 lines, -6 lines 0 comments Download

Messages

Total messages: 5 (0 generated)
lgombos
cleanup. PTAL.
6 years, 5 months ago (2014-07-01 01:46:27 UTC) #1
abarth-chromium
https://codereview.chromium.org/366473002/diff/1/public/web/WebRuntimeFeatures.h File public/web/WebRuntimeFeatures.h (left): https://codereview.chromium.org/366473002/diff/1/public/web/WebRuntimeFeatures.h#oldcode135 public/web/WebRuntimeFeatures.h:135: BLINK_EXPORT static void enableLaxMixedContentChecking(bool); This one was just added. ...
6 years, 5 months ago (2014-07-01 02:11:22 UTC) #2
lgombos
The CQ bit was checked by l.gombos@samsung.com
6 years, 5 months ago (2014-07-01 03:52:12 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/l.gombos@samsung.com/366473002/20001
6 years, 5 months ago (2014-07-01 03:53:11 UTC) #4
commit-bot: I haz the power
6 years, 5 months ago (2014-07-01 04:09:15 UTC) #5
Message was sent while issue was closed.
Change committed as 177269

Powered by Google App Engine
This is Rietveld 408576698