include/core/SkPicture.h - Issue 366443002: Implement SkRecord::willPlaybackBitmaps, cache in SkPicture

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: include/core/SkPicture.h

Issue 366443002: Implement SkRecord::willPlaybackBitmaps, cache in SkPicture (Closed) Base URL: https://skia.googlesource.com/skia.git@master

Patch Set: Mike's macro suggestion Created 6 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch

OLD	NEW
1	1

2 /*	2 /*

3 * Copyright 2007 The Android Open Source Project	3 * Copyright 2007 The Android Open Source Project

4 *	4 *

5 * Use of this source code is governed by a BSD-style license that can be	5 * Use of this source code is governed by a BSD-style license that can be

6 * found in the LICENSE file.	6 * found in the LICENSE file.

7 */	7 */

8	8

9	9

10 #ifndef SkPicture_DEFINED	10 #ifndef SkPicture_DEFINED

(...skipping 294 matching lines...) Expand 10 before \| Expand all \| Expand 10 after Loading...
305 friend class SkPictureRecorder; // just for SkPicture-based constructor	305 friend class SkPictureRecorder; // just for SkPicture-based constructor

306 friend class SkGpuDevice;	306 friend class SkGpuDevice;

307 friend class GrGatherCanvas;	307 friend class GrGatherCanvas;

308 friend class GrGatherDevice;	308 friend class GrGatherDevice;

309 friend class SkDebugCanvas;	309 friend class SkDebugCanvas;

310	310

311 typedef SkRefCnt INHERITED;	311 typedef SkRefCnt INHERITED;

312	312

313 SkPicture(int width, int height, SkRecord*); // Takes ownership.	313 SkPicture(int width, int height, SkRecord*); // Takes ownership.

314 SkAutoTDelete<SkRecord> fRecord;	314 SkAutoTDelete<SkRecord> fRecord;

	315 bool fRecordWillPlayBackBitmaps; // cached
	mtklein 2014/07/02 15:53:08 I think the // cached here can go? Makes it seem I think the // cached here can go? Makes it seem like we're going to record it the first time we call willPlayBackBitmaps() instead of in the constructor. I'd be all for a // TODO: const, though. I think we can constify a bunch of this stuff once clone's gone. tomhudson 2014/07/02 19:21:33 Done. Show quoted text On 2014/07/02 15:53:08, mtklein wrote: > I think the // cached here can go? Makes it seem like we're going to record it > the first time we call willPlayBackBitmaps() instead of in the constructor. > > I'd be all for a // TODO: const, though. I think we can constify a bunch of > this stuff once clone's gone. Done.
315 };	316 };

316	317

317 #endif	318 #endif

OLD	NEW

« no previous file with comments | « gyp/core.gypi ('k') | src/core/SkPicture.cpp » ('j') | src/core/SkPicture.cpp » ('J')