Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(109)

Unified Diff: tests/standalone/io/http_client_request_test.dart

Issue 36643002: Don't close existing connection on HttpServer close (and stream cancel). (Closed) Base URL: https://dart.googlecode.com/svn/branches/bleeding_edge/dart
Patch Set: Fix 'disable keep-alive' on server close. Created 7 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « tests/standalone/io/http_client_connect_test.dart ('k') | tests/standalone/io/http_detach_socket_test.dart » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: tests/standalone/io/http_client_request_test.dart
diff --git a/tests/standalone/io/http_client_request_test.dart b/tests/standalone/io/http_client_request_test.dart
index 5b6dc302b94345dad1c36398eb4e99b8f8bd79ea..fb6dcd69f8d4db7022ed922d18d83e9e4f440907 100644
--- a/tests/standalone/io/http_client_request_test.dart
+++ b/tests/standalone/io/http_client_request_test.dart
@@ -12,9 +12,9 @@ import "package:expect/expect.dart";
void testClientRequest(Future handler(request)) {
HttpServer.bind("127.0.0.1", 0).then((server) {
server.listen((request) {
- request.listen((_) {}, onDone: () {
- request.response.close();
- }, onError: (e) {});
+ request.drain()
+ .then((_) => request.response.close())
+ .catchError((_) {});
});
var client = new HttpClient();
@@ -22,15 +22,11 @@ void testClientRequest(Future handler(request)) {
.then((request) {
return handler(request);
})
- .then((response) {
- response.listen((_) {}, onDone: () {
- client.close();
- server.close();
- });
- })
- .catchError((error) {
- server.close();
+ .then((response) => response.drain())
+ .catchError((_) {})
+ .whenComplete(() {
client.close();
+ server.close();
});
});
}
« no previous file with comments | « tests/standalone/io/http_client_connect_test.dart ('k') | tests/standalone/io/http_detach_socket_test.dart » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698