tests/standalone/io/http_detach_socket_test.dart - Issue 36643002: Don't close existing connection on HttpServer close (and stream cancel).

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: tests/standalone/io/http_detach_socket_test.dart

Issue 36643002: Don't close existing connection on HttpServer close (and stream cancel). (Closed) Base URL: https://dart.googlecode.com/svn/branches/bleeding_edge/dart

Patch Set: Always close idle connections. Created 7 years, 2 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« tests/standalone/io/http_client_connect_test.dart ('K') | « tests/standalone/io/http_client_request_test.dart ('k') | tests/standalone/io/http_server_early_server_close_test.dart » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: tests/standalone/io/http_detach_socket_test.dart

diff --git a/tests/standalone/io/http_detach_socket_test.dart b/tests/standalone/io/http_detach_socket_test.dart

index 6b38de25a0d9f787085a95d6972c6be2a4903cb1..cd03dfd7b0b248bdd1ea59a61362498fc2fb829e 100644

--- a/tests/standalone/io/http_detach_socket_test.dart

+++ b/tests/standalone/io/http_detach_socket_test.dart

@@ -60,10 +60,11 @@ void testBadServerDetachSocket() {

Socket.connect("127.0.0.1", server.port).then((socket) {

socket.write("GET / HTTP/1.1\r\n"

+ "Connection: Close\r\n"

Søren Gjesse 2013/10/23 13:23:25 "Connection: Close" should not be needed here.

Anders Johnsen 2013/10/23 14:12:34 Done.

"content-length: 0\r\n\r\n");

socket.listen((_) {}, onDone: () {

- socket.close();

- });

+ socket.close();

+ });

});

}