Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(8252)

Unified Diff: chrome/browser/ui/panels/base_panel_browser_test.h

Issue 366383002: Remove unused SkipTestIfIceWM() and SkipTestIfCompizWM() (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Created 6 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | chrome/browser/ui/panels/base_panel_browser_test.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/browser/ui/panels/base_panel_browser_test.h
diff --git a/chrome/browser/ui/panels/base_panel_browser_test.h b/chrome/browser/ui/panels/base_panel_browser_test.h
index abe638f2049b32e60df3028cf8caa96727252f00..aa2e570ea348a778d0660f35e52f3fe0cccf2b15 100644
--- a/chrome/browser/ui/panels/base_panel_browser_test.h
+++ b/chrome/browser/ui/panels/base_panel_browser_test.h
@@ -42,19 +42,6 @@ class BasePanelBrowserTest : public InProcessBrowserTest {
BasePanelBrowserTest();
virtual ~BasePanelBrowserTest();
- // Linux bots use icewm which activate windows in ways that break
- // certain panel tests. Skip those tests when running on the bots.
- // We do not disable the tests to make it easy for developers to run
- // them locally. [Icewm always activates a window when shown.]
- bool SkipTestIfIceWM();
-
- // Gnome running compiz refuses to activate a window that was initially
- // created as inactive, causing certain panel tests to fail. These tests
- // pass fine on the bots, but fail for developers as Gnome running compiz
- // is the typical linux dev machine configuration. We do not disable the
- // tests to ensure we still have coverage on the bots.
- bool SkipTestIfCompizWM();
-
virtual void SetUpCommandLine(base::CommandLine* command_line) OVERRIDE;
virtual void SetUpOnMainThread() OVERRIDE;
« no previous file with comments | « no previous file | chrome/browser/ui/panels/base_panel_browser_test.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698