Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1342)

Issue 366383002: Remove unused SkipTestIfIceWM() and SkipTestIfCompizWM() (Closed)

Created:
6 years, 5 months ago by pkotwicz
Modified:
6 years, 5 months ago
Reviewers:
Dmitry Titov, jianli
CC:
chromium-reviews, jennb, jianli, dcheng
Project:
chromium
Visibility:
Public.

Description

Remove unused SkipTestIfIceWM() and SkipTestIfCompizWM() BUG=None TEST=None Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=284449

Patch Set 1 #

Patch Set 2 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+0 lines, -29 lines) Patch
M chrome/browser/ui/panels/base_panel_browser_test.h View 1 chunk +0 lines, -13 lines 0 comments Download
M chrome/browser/ui/panels/base_panel_browser_test.cc View 1 1 chunk +0 lines, -16 lines 0 comments Download

Messages

Total messages: 13 (0 generated)
pkotwicz
jianli@ PTAL I am removing these methods because they are unused. I believe that we ...
6 years, 5 months ago (2014-07-05 14:29:49 UTC) #1
pkotwicz
jianli@ seems to be OOO. dimich@ PTAL
6 years, 5 months ago (2014-07-14 17:55:44 UTC) #2
pkotwicz
dimich@ Ping?
6 years, 5 months ago (2014-07-17 18:30:09 UTC) #3
Dmitry Titov
lgtm
6 years, 5 months ago (2014-07-17 18:43:32 UTC) #4
pkotwicz
The CQ bit was checked by pkotwicz@chromium.org
6 years, 5 months ago (2014-07-17 19:14:13 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/pkotwicz@chromium.org/366383002/1
6 years, 5 months ago (2014-07-17 19:20:48 UTC) #6
commit-bot: I haz the power
FYI, CQ is re-trying this CL (attempt #1). The failing builders are: android_aosp on tryserver.chromium ...
6 years, 5 months ago (2014-07-17 21:03:14 UTC) #7
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 5 months ago (2014-07-17 21:07:03 UTC) #8
commit-bot: I haz the power
Try jobs failed on following builders: ios_dbg_simulator on tryserver.chromium (http://build.chromium.org/p/tryserver.chromium/builders/ios_dbg_simulator/builds/171338) ios_rel_device on tryserver.chromium (http://build.chromium.org/p/tryserver.chromium/builders/ios_rel_device/builds/160384) ios_rel_device_ninja ...
6 years, 5 months ago (2014-07-17 21:07:04 UTC) #9
pkotwicz
The CQ bit was checked by pkotwicz@chromium.org
6 years, 5 months ago (2014-07-21 15:10:52 UTC) #10
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/pkotwicz@chromium.org/366383002/20001
6 years, 5 months ago (2014-07-21 15:12:08 UTC) #11
commit-bot: I haz the power
FYI, CQ is re-trying this CL (attempt #1). The failing builders are: ios_dbg_simulator on tryserver.chromium ...
6 years, 5 months ago (2014-07-21 17:11:46 UTC) #12
commit-bot: I haz the power
6 years, 5 months ago (2014-07-21 17:21:41 UTC) #13
Message was sent while issue was closed.
Change committed as 284449

Powered by Google App Engine
This is Rietveld 408576698