Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(825)

Unified Diff: components/infobars/test/infobar_test.cc

Issue 366373002: [Variations] Bring variations_http_header_provider to variations component (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: properly add infobar_test Created 6 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « components/infobars.gypi ('k') | components/variations.gypi » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: components/infobars/test/infobar_test.cc
diff --git a/components/infobars/test/infobar_test.cc b/components/infobars/test/infobar_test.cc
new file mode 100644
index 0000000000000000000000000000000000000000..49eea18e5d90c4e3aed30ca445abcc493422c51c
--- /dev/null
+++ b/components/infobars/test/infobar_test.cc
@@ -0,0 +1,31 @@
+// Copyright 2014 The Chromium Authors. All rights reserved.
+// Use of this source code is governed by a BSD-style license that can be
+// found in the LICENSE file.
+
+#include "base/logging.h"
+#include "base/memory/scoped_ptr.h"
+#include "components/infobars/core/confirm_infobar_delegate.h"
+#include "components/infobars/core/infobar.h"
+
+// Provides dummy definitions of static variables and functions that are
+// declared in the component but defined in the embedder in order to allow
+// components_unittests to link.
+// TODO(blundell): The component shouldn't be declaring statics that it's not
+// defining. crbug.com/386171
+
+// On Android, these variables are defined in ../core/infobar_android.cc.
+#if !defined(OS_ANDROID)
+const int infobars::InfoBar::kSeparatorLineHeight = 0;
+const int infobars::InfoBar::kDefaultArrowTargetHeight = 0;
+const int infobars::InfoBar::kMaximumArrowTargetHeight = 0;
+const int infobars::InfoBar::kDefaultArrowTargetHalfWidth =
+ kDefaultArrowTargetHeight;
Peter Kasting 2014/07/08 18:54:40 Does this need to be nonzero? If not, make it zer
Mathieu 2014/07/08 19:01:12 I've set the to the values in infobar_view.cc
+const int infobars::InfoBar::kMaximumArrowTargetHalfWidth = 0;
+const int infobars::InfoBar::kDefaultBarTargetHeight = 0;
+#endif
+
+scoped_ptr<infobars::InfoBar> ConfirmInfoBarDelegate::CreateInfoBar(
+ scoped_ptr<ConfirmInfoBarDelegate> delegate) {
+ NOTREACHED();
+ return scoped_ptr<infobars::InfoBar>();
+}
« no previous file with comments | « components/infobars.gypi ('k') | components/variations.gypi » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698