Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(114)

Issue 366273002: Update onc_spec.html to match implementation. (Closed)

Created:
6 years, 5 months ago by pneubeck (no reviews)
Modified:
6 years, 5 months ago
Reviewers:
David Roche, pastarmovj
CC:
chromium-reviews, stevenjb+watch_chromium.org, oshima+watch_chromium.org
Project:
chromium
Visibility:
Public.

Description

Update onc_spec.html to match implementation. onc_validator had some deviations from the onc_spec. This updates the onc_spec. BUG=386182 R=davidroche@chromium.org, pastarmovj@chromium.org Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=282016

Patch Set 1 #

Total comments: 1

Patch Set 2 : Addressed comment. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+5 lines, -9 lines) Patch
M chromeos/network/onc/onc_validator.cc View 1 chunk +0 lines, -6 lines 0 comments Download
M components/onc/docs/onc_spec.html View 1 2 chunks +5 lines, -3 lines 0 comments Download

Messages

Total messages: 14 (0 generated)
pneubeck (no reviews)
ptal
6 years, 5 months ago (2014-07-04 07:32:55 UTC) #1
David Roche
https://codereview.chromium.org/366273002/diff/1/components/onc/docs/onc_spec.html File components/onc/docs/onc_spec.html (right): https://codereview.chromium.org/366273002/diff/1/components/onc/docs/onc_spec.html#newcode220 components/onc/docs/onc_spec.html:220: <span class="field">Certificates</span>) should be present. It should not be ...
6 years, 5 months ago (2014-07-07 17:22:44 UTC) #2
pneubeck (no reviews)
(needs an lgtm for committing)
6 years, 5 months ago (2014-07-08 09:37:55 UTC) #3
David Roche
lgtm
6 years, 5 months ago (2014-07-08 17:10:04 UTC) #4
pneubeck (no reviews)
The CQ bit was checked by pneubeck@chromium.org
6 years, 5 months ago (2014-07-08 17:22:28 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/pneubeck@chromium.org/366273002/20001
6 years, 5 months ago (2014-07-08 17:23:31 UTC) #6
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 5 months ago (2014-07-08 17:23:33 UTC) #7
commit-bot: I haz the power
No LGTM from a valid reviewer yet. Only full committers are accepted. Even if an ...
6 years, 5 months ago (2014-07-08 17:23:34 UTC) #8
pneubeck (no reviews)
Oh, David, you're not a full committer yet. @Julian, please rubber stamp. Thanks
6 years, 5 months ago (2014-07-09 07:39:07 UTC) #9
pastarmovj
lgtm
6 years, 5 months ago (2014-07-09 08:50:22 UTC) #10
pneubeck (no reviews)
The CQ bit was checked by pneubeck@chromium.org
6 years, 5 months ago (2014-07-09 09:37:49 UTC) #11
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/pneubeck@chromium.org/366273002/20001
6 years, 5 months ago (2014-07-09 09:38:58 UTC) #12
pneubeck (no reviews)
The CQ bit was unchecked by pneubeck@chromium.org
6 years, 5 months ago (2014-07-09 13:06:30 UTC) #13
pneubeck (no reviews)
6 years, 5 months ago (2014-07-09 13:11:47 UTC) #14
Message was sent while issue was closed.
Committed patchset #2 manually as r282016 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698