[fsp] Add support for creating directories.

[fsp] Add support for creating directories.

This is the first R/W operation. The new event in IDL has [nodoc], since we
don't want to show it on developer.chrome.com before most of the R/W features
are done.

TEST=unit_tests, browser_tests: *FileSystemProvider*CreateDirectory*
BUG=391362
Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=282554

[mtomasz, 2014-07-07 00:44:44]

@kinaba: PTAL at C++.
@hirono: PTAL at JS.
@benwells: PTAL at IDL.

Thanks.

[hirono, 2014-07-07 03:00:52]

lgtm with nits.

https://codereview.chromium.org/366263002/diff/20001/chrome/renderer/resource...
File
chrome/renderer/resources/extensions/file_system_provider_custom_bindings.js
(right):

https://codereview.chromium.org/366263002/diff/20001/chrome/renderer/resource...
chrome/renderer/resources/extensions/file_system_provider_custom_bindings.js:47:
* @param {function(Array.<*>)} Closure to be called with massaged arguments.
nit: 'dispatch'

https://codereview.chromium.org/366263002/diff/20001/chrome/test/data/extensi...
File
chrome/test/data/extensions/api_test/file_system_provider/create_directory/test.js
(right):

https://codereview.chromium.org/366263002/diff/20001/chrome/test/data/extensi...
chrome/test/data/extensions/api_test/file_system_provider/create_directory/test.js:150:
chrome.test.fail();
nit: Please add an error message.

[kinaba, 2014-07-07 05:24:08]

lgtm

https://codereview.chromium.org/366263002/diff/20001/chrome/browser/chromeos/...
File chrome/browser/chromeos/file_system_provider/operations/create_directory.h
(right):

https://codereview.chromium.org/366263002/diff/20001/chrome/browser/chromeos/...
chrome/browser/chromeos/file_system_provider/operations/create_directory.h:28:
// Created a directory. If |recursive| is set to true, then creates also all
nit: Created -> Creates

[mtomasz, 2014-07-07 05:53:55]

https://codereview.chromium.org/366263002/diff/20001/chrome/browser/chromeos/...
File chrome/browser/chromeos/file_system_provider/operations/create_directory.h
(right):

https://codereview.chromium.org/366263002/diff/20001/chrome/browser/chromeos/...
chrome/browser/chromeos/file_system_provider/operations/create_directory.h:28:
// Created a directory. If |recursive| is set to true, then creates also all
On 2014/07/07 05:24:08, kinaba wrote:
> nit: Created -> Creates

Done.

https://codereview.chromium.org/366263002/diff/20001/chrome/renderer/resource...
File
chrome/renderer/resources/extensions/file_system_provider_custom_bindings.js
(right):

https://codereview.chromium.org/366263002/diff/20001/chrome/renderer/resource...
chrome/renderer/resources/extensions/file_system_provider_custom_bindings.js:47:
* @param {function(Array.<*>)} Closure to be called with massaged arguments.
On 2014/07/07 03:00:52, hirono wrote:
> nit: 'dispatch'

Done.

https://codereview.chromium.org/366263002/diff/20001/chrome/test/data/extensi...
File
chrome/test/data/extensions/api_test/file_system_provider/create_directory/test.js
(right):

https://codereview.chromium.org/366263002/diff/20001/chrome/test/data/extensi...
chrome/test/data/extensions/api_test/file_system_provider/create_directory/test.js:150:
chrome.test.fail();
On 2014/07/07 03:00:52, hirono wrote:
> nit: Please add an error message.

Done.

[mtomasz, 2014-07-08 02:15:45]

On 2014/07/07 05:53:55, mtomasz wrote:
>
https://codereview.chromium.org/366263002/diff/20001/chrome/browser/chromeos/...
> File
chrome/browser/chromeos/file_system_provider/operations/create_directory.h
> (right):
> 
>
https://codereview.chromium.org/366263002/diff/20001/chrome/browser/chromeos/...
> chrome/browser/chromeos/file_system_provider/operations/create_directory.h:28:
> // Created a directory. If |recursive| is set to true, then creates also all
> On 2014/07/07 05:24:08, kinaba wrote:
> > nit: Created -> Creates
> 
> Done.
> 
>
https://codereview.chromium.org/366263002/diff/20001/chrome/renderer/resource...
> File
> chrome/renderer/resources/extensions/file_system_provider_custom_bindings.js
> (right):
> 
>
https://codereview.chromium.org/366263002/diff/20001/chrome/renderer/resource...
>
chrome/renderer/resources/extensions/file_system_provider_custom_bindings.js:47:
> * @param {function(Array.<*>)} Closure to be called with massaged arguments.
> On 2014/07/07 03:00:52, hirono wrote:
> > nit: 'dispatch'
> 
> Done.
> 
>
https://codereview.chromium.org/366263002/diff/20001/chrome/test/data/extensi...
> File
>
chrome/test/data/extensions/api_test/file_system_provider/create_directory/test.js
> (right):
> 
>
https://codereview.chromium.org/366263002/diff/20001/chrome/test/data/extensi...
>
chrome/test/data/extensions/api_test/file_system_provider/create_directory/test.js:150:
> chrome.test.fail();
> On 2014/07/07 03:00:52, hirono wrote:
> > nit: Please add an error message.
> 
> Done.

@kalman: PTAL at IDL. Thanks.

[not at google - send to devlin, 2014-07-08 16:29:43]

https://codereview.chromium.org/366263002/diff/60001/chrome/common/extensions...
File chrome/common/extensions/api/file_system_provider.idl (right):

https://codereview.chromium.org/366263002/diff/60001/chrome/common/extensions...
chrome/common/extensions/api/file_system_provider.idl:233: // already exists. If
<code>recursive</code> is true, then all of the
it would be nice (generally speaking) if comments like "If
<code>exclusive</code> is set to true, then the operation should fail if the
target directory already exists" were actually on the
CreateDirectoryRequestedOptions dictionary itself, rather than here.

https://codereview.chromium.org/366263002/diff/60001/chrome/common/extensions...
chrome/common/extensions/api/file_system_provider.idl:235: [maxListeners=1,
nodoc] static void onCreateDirectoryRequested(
why is this nodoc?

[mtomasz, 2014-07-09 02:08:30]

https://codereview.chromium.org/366263002/diff/60001/chrome/common/extensions...
File chrome/common/extensions/api/file_system_provider.idl (right):

https://codereview.chromium.org/366263002/diff/60001/chrome/common/extensions...
chrome/common/extensions/api/file_system_provider.idl:233: // already exists. If
<code>recursive</code> is true, then all of the
On 2014/07/08 16:29:43, kalman wrote:
> it would be nice (generally speaking) if comments like "If
> <code>exclusive</code> is set to true, then the operation should fail if the
> target directory already exists" were actually on the
> CreateDirectoryRequestedOptions dictionary itself, rather than here.

Let me clean up all of the comments in a separate CL.

https://codereview.chromium.org/366263002/diff/60001/chrome/common/extensions...
chrome/common/extensions/api/file_system_provider.idl:235: [maxListeners=1,
nodoc] static void onCreateDirectoryRequested(
On 2014/07/08 16:29:43, kalman wrote:
> why is this nodoc?

We don't want it on developer.chrome.com yet.

[not at google - send to devlin, 2014-07-09 02:34:40]

https://codereview.chromium.org/366263002/diff/60001/chrome/common/extensions...
File chrome/common/extensions/api/file_system_provider.idl (right):

https://codereview.chromium.org/366263002/diff/60001/chrome/common/extensions...
chrome/common/extensions/api/file_system_provider.idl:235: [maxListeners=1,
nodoc] static void onCreateDirectoryRequested(
On 2014/07/09 02:08:30, mtomasz wrote:
> On 2014/07/08 16:29:43, kalman wrote:
> > why is this nodoc?
> 
> We don't want it on http://developer.chrome.com yet.

why not?

[not at google - send to devlin, 2014-07-09 02:39:10]

https://codereview.chromium.org/366263002/diff/60001/chrome/common/extensions...
File chrome/common/extensions/api/file_system_provider.idl (right):

https://codereview.chromium.org/366263002/diff/60001/chrome/common/extensions...
chrome/common/extensions/api/file_system_provider.idl:235: [maxListeners=1,
nodoc] static void onCreateDirectoryRequested(
On 2014/07/09 02:34:39, kalman wrote:
> On 2014/07/09 02:08:30, mtomasz wrote:
> > On 2014/07/08 16:29:43, kalman wrote:
> > > why is this nodoc?
> > 
> > We don't want it on http://developer.chrome.com yet.
> 
> why not?

i.e. because if it's that the API isn't ready then a better way to do all of
this is to restrict it to dev channel or whatever rather than not documenting
it.

[mtomasz, 2014-07-09 04:03:11]

https://codereview.chromium.org/366263002/diff/60001/chrome/common/extensions...
File chrome/common/extensions/api/file_system_provider.idl (right):

https://codereview.chromium.org/366263002/diff/60001/chrome/common/extensions...
chrome/common/extensions/api/file_system_provider.idl:235: [maxListeners=1,
nodoc] static void onCreateDirectoryRequested(
On 2014/07/09 02:39:10, kalman wrote:
> On 2014/07/09 02:34:39, kalman wrote:
> > On 2014/07/09 02:08:30, mtomasz wrote:
> > > On 2014/07/08 16:29:43, kalman wrote:
> > > > why is this nodoc?
> > > 
> > > We don't want it on http://developer.chrome.com yet.
> > 
> > why not?
> 
> i.e. because if it's that the API isn't ready then a better way to do all of
> this is to restrict it to dev channel or whatever rather than not documenting
> it.

The API is already restricted to build from sources only. However, since the
read-only version is almost finished, we may want to enable it soon for dev
users. However, R/W is far from ready, and I don't want users to use it yet.

Hence, my plan was to avoid publishing documentation for R/W functions until it
is reasonably working.

However, I don't have very strong feelings here. If you think that we should
publish the doc for stuff being worked on, I'll remove [nodoc]. Let me know.

[not at google - send to devlin, 2014-07-09 13:28:58]

lgtm

https://codereview.chromium.org/366263002/diff/60001/chrome/common/extensions...
File chrome/common/extensions/api/file_system_provider.idl (right):

https://codereview.chromium.org/366263002/diff/60001/chrome/common/extensions...
chrome/common/extensions/api/file_system_provider.idl:235: [maxListeners=1,
nodoc] static void onCreateDirectoryRequested(
On 2014/07/09 04:03:11, mtomasz wrote:
> On 2014/07/09 02:39:10, kalman wrote:
> > On 2014/07/09 02:34:39, kalman wrote:
> > > On 2014/07/09 02:08:30, mtomasz wrote:
> > > > On 2014/07/08 16:29:43, kalman wrote:
> > > > > why is this nodoc?
> > > > 
> > > > We don't want it on http://developer.chrome.com yet.
> > > 
> > > why not?
> > 
> > i.e. because if it's that the API isn't ready then a better way to do all of
> > this is to restrict it to dev channel or whatever rather than not
documenting
> > it.
> 
> The API is already restricted to build from sources only. However, since the
> read-only version is almost finished, we may want to enable it soon for dev
> users. However, R/W is far from ready, and I don't want users to use it yet.
> 
> Hence, my plan was to avoid publishing documentation for R/W functions until
it
> is reasonably working.
> 
> However, I don't have very strong feelings here. If you think that we should
> publish the doc for stuff being worked on, I'll remove [nodoc]. Let me know.

Ah I see. Yeah, nodoc is fine then.

[mtomasz, 2014-07-10 02:23:08]

The CQ bit was checked by mtomasz@chromium.org

[commit-bot: I haz the power, 2014-07-10 02:24:30]

CQ is trying da patch. Follow status at
 https://chromium-status.appspot.com/cq/mtomasz@chromium.org/366263002/60001

[commit-bot: I haz the power, 2014-07-10 02:29:09]

FYI, CQ is re-trying this CL (attempt #1).
The failing builders are:
  android_dbg on tryserver.chromium
(http://build.chromium.org/p/tryserver.chromium/builders/android_dbg/builds/20...)
  chromium_presubmit on tryserver.chromium
(http://build.chromium.org/p/tryserver.chromium/builders/chromium_presubmit/bu...)
  ios_rel_device_ninja on tryserver.chromium
(http://build.chromium.org/p/tryserver.chromium/builders/ios_rel_device_ninja/...)
  linux_chromium_chromeos_rel on tryserver.chromium
(http://build.chromium.org/p/tryserver.chromium/builders/linux_chromium_chrome...)
  win8_chromium_rel on tryserver.chromium
(http://build.chromium.org/p/tryserver.chromium/builders/win8_chromium_rel/bui...)

[commit-bot: I haz the power, 2014-07-10 02:32:25]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2014-07-10 02:32:26]

Try jobs failed on following builders:
  ios_rel_device_ninja on tryserver.chromium
(http://build.chromium.org/p/tryserver.chromium/builders/ios_rel_device_ninja/...)

[mtomasz, 2014-07-10 05:03:29]

The CQ bit was checked by mtomasz@chromium.org

[commit-bot: I haz the power, 2014-07-10 05:04:16]

CQ is trying da patch. Follow status at
 https://chromium-status.appspot.com/cq/mtomasz@chromium.org/366263002/60001

[commit-bot: I haz the power, 2014-07-10 05:08:30]

FYI, CQ is re-trying this CL (attempt #1).
The failing builders are:
  android_dbg on tryserver.chromium
(http://build.chromium.org/p/tryserver.chromium/builders/android_dbg/builds/20...)
  chromium_presubmit on tryserver.chromium
(http://build.chromium.org/p/tryserver.chromium/builders/chromium_presubmit/bu...)
  ios_rel_device_ninja on tryserver.chromium
(http://build.chromium.org/p/tryserver.chromium/builders/ios_rel_device_ninja/...)
  linux_chromium_chromeos_rel on tryserver.chromium
(http://build.chromium.org/p/tryserver.chromium/builders/linux_chromium_chrome...)
  win8_chromium_rel on tryserver.chromium
(http://build.chromium.org/p/tryserver.chromium/builders/win8_chromium_rel/bui...)

[commit-bot: I haz the power, 2014-07-10 05:10:39]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2014-07-10 05:10:40]

Try jobs failed on following builders:
  ios_rel_device_ninja on tryserver.chromium
(http://build.chromium.org/p/tryserver.chromium/builders/ios_rel_device_ninja/...)

[mtomasz, 2014-07-10 07:02:39]

The CQ bit was checked by mtomasz@chromium.org

[commit-bot: I haz the power, 2014-07-10 07:04:19]

CQ is trying da patch. Follow status at
 https://chromium-status.appspot.com/cq/mtomasz@chromium.org/366263002/60001

[commit-bot: I haz the power, 2014-07-10 07:10:07]

FYI, CQ is re-trying this CL (attempt #1).
The failing builders are:
  android_dbg on tryserver.chromium
(http://build.chromium.org/p/tryserver.chromium/builders/android_dbg/builds/20...)
  chromium_presubmit on tryserver.chromium
(http://build.chromium.org/p/tryserver.chromium/builders/chromium_presubmit/bu...)
  ios_rel_device_ninja on tryserver.chromium
(http://build.chromium.org/p/tryserver.chromium/builders/ios_rel_device_ninja/...)
  linux_chromium_chromeos_rel on tryserver.chromium
(http://build.chromium.org/p/tryserver.chromium/builders/linux_chromium_chrome...)
  win8_chromium_rel on tryserver.chromium
(http://build.chromium.org/p/tryserver.chromium/builders/win8_chromium_rel/bui...)

[commit-bot: I haz the power, 2014-07-10 07:12:25]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2014-07-10 07:12:26]

Try jobs failed on following builders:
  ios_rel_device_ninja on tryserver.chromium
(http://build.chromium.org/p/tryserver.chromium/builders/ios_rel_device_ninja/...)

[mtomasz, 2014-07-10 08:43:56]

The CQ bit was checked by mtomasz@chromium.org

[commit-bot: I haz the power, 2014-07-10 08:44:22]

CQ is trying da patch. Follow status at
 https://chromium-status.appspot.com/cq/mtomasz@chromium.org/366263002/60001

[commit-bot: I haz the power, 2014-07-10 08:47:59]

FYI, CQ is re-trying this CL (attempt #1).
The failing builders are:
  android_dbg on tryserver.chromium
(http://build.chromium.org/p/tryserver.chromium/builders/android_dbg/builds/20...)
  chromium_presubmit on tryserver.chromium
(http://build.chromium.org/p/tryserver.chromium/builders/chromium_presubmit/bu...)
  ios_rel_device_ninja on tryserver.chromium
(http://build.chromium.org/p/tryserver.chromium/builders/ios_rel_device_ninja/...)
  linux_chromium_chromeos_rel on tryserver.chromium
(http://build.chromium.org/p/tryserver.chromium/builders/linux_chromium_chrome...)
  win8_chromium_rel on tryserver.chromium
(http://build.chromium.org/p/tryserver.chromium/builders/win8_chromium_rel/bui...)

[commit-bot: I haz the power, 2014-07-10 08:50:00]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2014-07-10 08:50:01]

Try jobs failed on following builders:
  ios_rel_device_ninja on tryserver.chromium
(http://build.chromium.org/p/tryserver.chromium/builders/ios_rel_device_ninja/...)

[mtomasz, 2014-07-11 00:42:26]

The CQ bit was checked by mtomasz@chromium.org

[commit-bot: I haz the power, 2014-07-11 00:43:46]

CQ is trying da patch. Follow status at
 https://chromium-status.appspot.com/cq/mtomasz@chromium.org/366263002/80001

[commit-bot: I haz the power, 2014-07-11 05:07:07]

Change committed as 282554