Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(471)

Issue 366243004: Cleanup: Remove SkUTF16_Str API. (Closed)

Created:
6 years, 5 months ago by tfarina
Modified:
6 years, 5 months ago
Reviewers:
mtklein, reed1
CC:
reviews_skia.org
Base URL:
https://skia.googlesource.com/skia.git@master
Project:
skia
Visibility:
Public.

Description

Cleanup: Remove SkUTF16_Str API. It does not have any users in Skia, Blink and Chromium. BUG=None TEST=make all R=mtklein@google.com Committed: https://skia.googlesource.com/skia/+/e53363fa7c3db90c3f6e54fae1786a38de98c4d3

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+0 lines, -24 lines) Patch
M include/core/SkOSFile.h View 1 chunk +0 lines, -13 lines 0 comments Download
M src/utils/SkOSFile.cpp View 1 chunk +0 lines, -11 lines 0 comments Download

Messages

Total messages: 6 (0 generated)
tfarina
6 years, 5 months ago (2014-07-04 21:14:36 UTC) #1
mtklein
+reed for include/ LGTM. I also cannot see any users.
6 years, 5 months ago (2014-07-07 12:58:32 UTC) #2
reed1
at one time, this was for WIN file iterators. lgtm
6 years, 5 months ago (2014-07-07 14:02:45 UTC) #3
tfarina
The CQ bit was checked by tfarina@chromium.org
6 years, 5 months ago (2014-07-09 15:58:03 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://skia-tree-status.appspot.com/cq/tfarina@chromium.org/366243004/1
6 years, 5 months ago (2014-07-09 15:58:29 UTC) #5
commit-bot: I haz the power
6 years, 5 months ago (2014-07-09 16:18:09 UTC) #6
Message was sent while issue was closed.
Change committed as e53363fa7c3db90c3f6e54fae1786a38de98c4d3

Powered by Google App Engine
This is Rietveld 408576698