Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1007)

Unified Diff: content/renderer/media/video_track_adapter.cc

Issue 366243003: VideoTrackAdapter: Add passing frames monitor, notify MSVCS -> MSVTrack(s) (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: grunell@ comments and added a UT with 1 source muted pinging two tracks. Created 6 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: content/renderer/media/video_track_adapter.cc
diff --git a/content/renderer/media/video_track_adapter.cc b/content/renderer/media/video_track_adapter.cc
index e51f8427bef23e69f86cae7de12ae5677e2bd70b..23c2f9ceaaf5ac80fa94e374b6c36459629861ae 100644
--- a/content/renderer/media/video_track_adapter.cc
+++ b/content/renderer/media/video_track_adapter.cc
@@ -17,6 +17,12 @@ namespace content {
namespace {
+// Amount of frame intervals to wait before considering the source as muted, for
+// the first frame and under normal conditions, respectively. First frame might
+// take longer to arrive due to source startup.
+const float kFirstFrameTimeoutInFrameIntervals = 100.0f;
+const float kNormalFrameTimeoutInFrameIntervals = 25.0f;
+
// Empty method used for keeping a reference to the original media::VideoFrame
// in VideoFrameResolutionAdapter::DeliverFrame if cropping is needed.
// The reference to |frame| is kept in the closure that calls this method.
@@ -301,7 +307,9 @@ bool VideoTrackAdapter::VideoFrameResolutionAdapter::IsEmpty() const {
VideoTrackAdapter::VideoTrackAdapter(
const scoped_refptr<base::MessageLoopProxy>& io_message_loop)
: io_message_loop_(io_message_loop),
- renderer_task_runner_(base::MessageLoopProxy::current()) {
+ renderer_task_runner_(base::MessageLoopProxy::current()),
+ frame_counter_(0),
+ source_frame_rate_(0.0f) {
DCHECK(io_message_loop_);
}
@@ -309,14 +317,23 @@ VideoTrackAdapter::~VideoTrackAdapter() {
DCHECK(adapters_.empty());
}
-void VideoTrackAdapter::AddTrack(const MediaStreamVideoTrack* track,
- VideoCaptureDeliverFrameCB frame_callback,
- int max_width,
- int max_height,
- double min_aspect_ratio,
- double max_aspect_ratio,
- double max_frame_rate) {
+void VideoTrackAdapter::AddTrack(
+ const MediaStreamVideoTrack* track,
+ VideoCaptureDeliverFrameCB frame_callback,
+ int max_width,
+ int max_height,
+ double min_aspect_ratio,
+ double max_aspect_ratio,
+ double max_frame_rate,
+ double source_frame_rate,
+ const OnMutedCallback& on_muted_state_callback) {
DCHECK(thread_checker_.CalledOnValidThread());
+ // Track monitoring should be scheduled before AddTrackOnIO() so it can find
+ // |adapters_| empty.
+ io_message_loop_->PostTask(
+ FROM_HERE,
+ base::Bind(&VideoTrackAdapter::StartTrackMonitoringOnIO,
+ this, on_muted_state_callback, source_frame_rate));
io_message_loop_->PostTask(
FROM_HERE,
base::Bind(&VideoTrackAdapter::AddTrackOnIO,
@@ -360,6 +377,24 @@ void VideoTrackAdapter::RemoveTrack(const MediaStreamVideoTrack* track) {
base::Bind(&VideoTrackAdapter::RemoveTrackOnIO, this, track));
}
+void VideoTrackAdapter::StartTrackMonitoringOnIO(
+ const OnMutedCallback& on_muted_state_callback,
+ double source_frame_rate) {
+ DCHECK(io_message_loop_->BelongsToCurrentThread());
+ // Only trigger monitoring for the first Track.
+ if (adapters_.size())
Henrik Grunell 2014/07/10 08:41:34 if (adapters_.size() > 0)
mcasas 2014/07/10 11:59:04 Done.
+ return;
+ DCHECK_NE(source_frame_rate, 0.0f);
+ source_frame_rate_ = source_frame_rate;
+ DVLOG(1) << "Monitoring frame creation, first (large) delay: "
+ << (kFirstFrameTimeoutInFrameIntervals / source_frame_rate_) << "s";
+ io_message_loop_->PostDelayedTask(FROM_HERE,
+ base::Bind(&VideoTrackAdapter::CheckFramesReceivedOnIO, this,
+ on_muted_state_callback, frame_counter_),
+ base::TimeDelta::FromSecondsD(kFirstFrameTimeoutInFrameIntervals /
+ source_frame_rate_));
+}
+
void VideoTrackAdapter::RemoveTrackOnIO(const MediaStreamVideoTrack* track) {
DCHECK(io_message_loop_->BelongsToCurrentThread());
for (FrameAdapters::iterator it = adapters_.begin();
@@ -378,10 +413,26 @@ void VideoTrackAdapter::DeliverFrameOnIO(
const base::TimeTicks& estimated_capture_time) {
DCHECK(io_message_loop_->BelongsToCurrentThread());
TRACE_EVENT0("video", "VideoTrackAdapter::DeliverFrameOnIO");
+ ++frame_counter_;
for (FrameAdapters::iterator it = adapters_.begin();
it != adapters_.end(); ++it) {
(*it)->DeliverFrame(frame, format, estimated_capture_time);
}
}
+void VideoTrackAdapter::CheckFramesReceivedOnIO(
+ const OnMutedCallback& set_muted_state_callback,
+ uint64 old_frame_counter_snapshot) {
+ DCHECK(io_message_loop_->BelongsToCurrentThread());
+ DVLOG_IF(1, old_frame_counter_snapshot == frame_counter_)
+ << "No frames have passed, setting source as Muted.";
+ set_muted_state_callback.Run(old_frame_counter_snapshot == frame_counter_);
+
+ io_message_loop_->PostDelayedTask(FROM_HERE,
Henrik Grunell 2014/07/10 08:41:34 Add a comment about that we'll keep monitoring unt
mcasas 2014/07/10 11:59:04 Done.
+ base::Bind(&VideoTrackAdapter::CheckFramesReceivedOnIO, this,
+ set_muted_state_callback, frame_counter_),
+ base::TimeDelta::FromSecondsD(kNormalFrameTimeoutInFrameIntervals /
+ source_frame_rate_));
+}
+
} // namespace content

Powered by Google App Engine
This is Rietveld 408576698