Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(11)

Issue 366223006: createTreeWalker and createNodeIterator should deal with null NodeFilter (Closed)

Created:
6 years, 5 months ago by kangil_
Modified:
6 years, 5 months ago
Reviewers:
tkent, haraken, Jens Widell
CC:
blink-reviews, blink-reviews-bindings_chromium.org, arv+blink, abarth-chromium
Base URL:
https://chromium.googlesource.com/chromium/blink.git@master
Project:
blink
Visibility:
Public.

Description

createTreeWalker and createNodeIterator should deal with null NodeFilter in Document. spec: http://dom.spec.whatwg.org/#interface-document According to spec, optional third parameter(NodeFilter) of createTreeWalker and createNodeIterator can be null. So this CL modified behavior as per specified. TEST=LayoutTests/fast/dom/TreeWalker/TreeWalker-basic.html ,LayoutTests/fast/dom/NodeIterator/NodeIterator-basic.html In addition, with this CL, Optional arguments to createTreeWalker should be optional (3 passed, null) test at http://w3c-test.org/dom/nodes/Document-createTreeWalker.html will be passed. Behavior in other browsers. *)FF: PASS *)IE: FAIL Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=177560

Patch Set 1 #

Patch Set 2 : Take review comment into consideration #

Total comments: 2

Patch Set 3 : Use fully qualified variable name #

Unified diffs Side-by-side diffs Delta from patch set Stats (+20 lines, -0 lines) Patch
M LayoutTests/fast/dom/NodeIterator/NodeIterator-basic.html View 1 2 1 chunk +8 lines, -0 lines 0 comments Download
M LayoutTests/fast/dom/NodeIterator/NodeIterator-basic-expected.txt View 1 1 chunk +1 line, -0 lines 0 comments Download
M LayoutTests/fast/dom/TreeWalker/TreeWalker-basic.html View 1 2 1 chunk +8 lines, -0 lines 0 comments Download
M LayoutTests/fast/dom/TreeWalker/TreeWalker-basic-expected.txt View 1 chunk +1 line, -0 lines 0 comments Download
M Source/bindings/core/v8/V8Binding.cpp View 1 chunk +2 lines, -0 lines 0 comments Download

Messages

Total messages: 10 (0 generated)
kangil_
PTAL
6 years, 5 months ago (2014-07-04 13:36:37 UTC) #1
haraken
LGTM
6 years, 5 months ago (2014-07-04 14:35:43 UTC) #2
Jens Widell
Same goes for Document.createNodeIterator(), and it is also fixed with this CL. Could be mentioned ...
6 years, 5 months ago (2014-07-04 16:00:57 UTC) #3
kangil_
PTAL, thanks!
6 years, 5 months ago (2014-07-05 01:59:00 UTC) #4
haraken
LGTM https://codereview.chromium.org/366223006/diff/20001/LayoutTests/fast/dom/TreeWalker/TreeWalker-basic.html File LayoutTests/fast/dom/TreeWalker/TreeWalker-basic.html (right): https://codereview.chromium.org/366223006/diff/20001/LayoutTests/fast/dom/TreeWalker/TreeWalker-basic.html#newcode124 LayoutTests/fast/dom/TreeWalker/TreeWalker-basic.html:124: var tw = document.createTreeWalker(document.body, 42, null); Nit: tw ...
6 years, 5 months ago (2014-07-05 02:02:11 UTC) #5
kangil_
Thanks and done! https://codereview.chromium.org/366223006/diff/20001/LayoutTests/fast/dom/TreeWalker/TreeWalker-basic.html File LayoutTests/fast/dom/TreeWalker/TreeWalker-basic.html (right): https://codereview.chromium.org/366223006/diff/20001/LayoutTests/fast/dom/TreeWalker/TreeWalker-basic.html#newcode124 LayoutTests/fast/dom/TreeWalker/TreeWalker-basic.html:124: var tw = document.createTreeWalker(document.body, 42, null); ...
6 years, 5 months ago (2014-07-05 02:10:50 UTC) #6
kangil_
The CQ bit was checked by kangil.han@samsung.com
6 years, 5 months ago (2014-07-05 02:11:14 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/kangil.han@samsung.com/366223006/40001
6 years, 5 months ago (2014-07-05 02:11:37 UTC) #8
commit-bot: I haz the power
FYI, CQ is re-trying this CL (attempt #1). The failing builders are: win_blink_rel on tryserver.blink ...
6 years, 5 months ago (2014-07-05 03:16:24 UTC) #9
commit-bot: I haz the power
6 years, 5 months ago (2014-07-05 04:14:55 UTC) #10
Message was sent while issue was closed.
Change committed as 177560

Powered by Google App Engine
This is Rietveld 408576698