Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(5)

Issue 366203002: Cleanup: Remove unused ntp_background_util.* component. (Closed)

Created:
6 years, 5 months ago by tfarina
Modified:
6 years, 5 months ago
Reviewers:
msw, Peter Kasting
CC:
chromium-reviews, tfarina, msw
Project:
chromium
Visibility:
Public.

Description

Cleanup: Remove unused ntp_background_util.* component. Nobody uses this API anymore. BUG=None TEST=None R=pkasting@chromium.org Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=282557

Patch Set 1 #

Patch Set 2 : REBASE #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -122 lines) Patch
M chrome/browser/ui/cocoa/bookmarks/bookmark_bar_toolbar_view.h View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/ui/cocoa/bookmarks/bookmark_bar_toolbar_view.mm View 1 chunk +0 lines, -1 line 0 comments Download
D chrome/browser/ui/ntp_background_util.h View 1 chunk +0 lines, -31 lines 0 comments Download
D chrome/browser/ui/ntp_background_util.cc View 1 chunk +0 lines, -86 lines 0 comments Download
M chrome/browser/ui/views/frame/browser_view.cc View 1 1 chunk +0 lines, -1 line 0 comments Download
M chrome/chrome_browser_ui.gypi View 1 1 chunk +0 lines, -2 lines 0 comments Download

Messages

Total messages: 6 (0 generated)
tfarina
6 years, 5 months ago (2014-07-03 23:32:30 UTC) #1
msw
LGTM!
6 years, 5 months ago (2014-07-07 19:51:23 UTC) #2
Peter Kasting
LGTM
6 years, 5 months ago (2014-07-07 20:08:07 UTC) #3
tfarina
The CQ bit was checked by tfarina@chromium.org
6 years, 5 months ago (2014-07-11 01:15:22 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/tfarina@chromium.org/366203002/20001
6 years, 5 months ago (2014-07-11 01:16:36 UTC) #5
commit-bot: I haz the power
6 years, 5 months ago (2014-07-11 05:14:23 UTC) #6
Message was sent while issue was closed.
Change committed as 282557

Powered by Google App Engine
This is Rietveld 408576698