Issue 366133003: Change AndroidHistoryProviderService to use CancelableTaskTracker (3/6)

Issue 366133003: Change AndroidHistoryProviderService to use CancelableTaskTracker (3/6) (Closed)

Created:
6 years, 5 months ago by sdefresne

Modified:
6 years, 5 months ago

Reviewers:
blundell

CC:
chromium-reviews, browser-components-watch_chromium.org

Base URL:
https://chromium.googlesource.com/chromium/src.git@cancelable_task_tracker.3

Project:
chromium

Visibility:
Public.

More Reviews

Description

Change AndroidHistoryProviderService to use CancelableTaskTracker (3/6) Change AndroidHistoryProviderService::MoveStatement to use base::CancelableTaskTracker instead of CancelableRequestConsumer. BUG=371818 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=283770

Patch Set 1 #

Patch Set 2 : clang-format #

Patch Set 3 : Rebase #

Patch Set 4 : Fix unit tests #

Created: 6 years, 5 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+55 lines, -46 lines)			Patch
M	chrome/browser/history/android/android_history_provider_service.h	View	1 2	2 chunks	+10 lines, -10 lines	0 comments	Download
M	chrome/browser/history/android/android_history_provider_service.cc	View		1 chunk	+16 lines, -10 lines	0 comments	Download
M	chrome/browser/history/android/android_history_provider_service_unittest.cc	View	1 2 3	3 chunks	+13 lines, -6 lines	0 comments	Download
M	chrome/browser/history/android/sqlite_cursor.h	View		3 chunks	+1 line, -3 lines	0 comments	Download
M	chrome/browser/history/android/sqlite_cursor.cc	View	1	3 chunks	+8 lines, -7 lines	0 comments	Download
M	chrome/browser/history/history_backend.h	View	1 2	1 chunk	+3 lines, -4 lines	0 comments	Download
M	chrome/browser/history/history_backend_android.cc	View		2 chunks	+4 lines, -6 lines	0 comments	Download

Messages

Total messages: 6 (0 generated)

Expand Messages | Collapse Messages

sdefresne

Could you please take a look? This is the third of a series of seven ...

6 years, 5 months ago (2014-07-03 17:18:02 UTC) #1

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/sdefresne@chromium.org/366133003/60001

6 years, 5 months ago (2014-07-17 08:28:29 UTC) #4

commit-bot: I haz the power

FYI, CQ is re-trying this CL (attempt #1). The failing builders are: win_chromium_rel on tryserver.chromium ...

6 years, 5 months ago (2014-07-17 11:48:50 UTC) #5

Message was sent while issue was closed.

Change committed as 283770

Expand Messages | Collapse Messages