Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(169)

Side by Side Diff: tools/check-static-initializers.sh

Issue 366123002: Revert "Reland^2 r22105 "Remove static initializer from isolate"" (Closed) Base URL: https://v8.googlecode.com/svn/branches/bleeding_edge
Patch Set: Created 6 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
« no previous file with comments | « src/sampler.cc ('k') | no next file » | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 #!/bin/bash 1 #!/bin/bash
2 # Copyright 2012 the V8 project authors. All rights reserved. 2 # Copyright 2012 the V8 project authors. All rights reserved.
3 # Redistribution and use in source and binary forms, with or without 3 # Redistribution and use in source and binary forms, with or without
4 # modification, are permitted provided that the following conditions are 4 # modification, are permitted provided that the following conditions are
5 # met: 5 # met:
6 # 6 #
7 # * Redistributions of source code must retain the above copyright 7 # * Redistributions of source code must retain the above copyright
8 # notice, this list of conditions and the following disclaimer. 8 # notice, this list of conditions and the following disclaimer.
9 # * Redistributions in binary form must reproduce the above 9 # * Redistributions in binary form must reproduce the above
10 # copyright notice, this list of conditions and the following 10 # copyright notice, this list of conditions and the following
(...skipping 14 matching lines...) Expand all
25 # THEORY OF LIABILITY, WHETHER IN CONTRACT, STRICT LIABILITY, OR TORT 25 # THEORY OF LIABILITY, WHETHER IN CONTRACT, STRICT LIABILITY, OR TORT
26 # (INCLUDING NEGLIGENCE OR OTHERWISE) ARISING IN ANY WAY OUT OF THE USE 26 # (INCLUDING NEGLIGENCE OR OTHERWISE) ARISING IN ANY WAY OUT OF THE USE
27 # OF THIS SOFTWARE, EVEN IF ADVISED OF THE POSSIBILITY OF SUCH DAMAGE. 27 # OF THIS SOFTWARE, EVEN IF ADVISED OF THE POSSIBILITY OF SUCH DAMAGE.
28 28
29 # Checks that the number of compilation units having at least one static 29 # Checks that the number of compilation units having at least one static
30 # initializer in d8 matches the one defined below. 30 # initializer in d8 matches the one defined below.
31 31
32 # Allow: 32 # Allow:
33 # - _GLOBAL__I__ZN2v810LineEditor6first_E 33 # - _GLOBAL__I__ZN2v810LineEditor6first_E
34 # - _GLOBAL__I__ZN2v88internal32AtomicOps_Internalx86CPUFeaturesE 34 # - _GLOBAL__I__ZN2v88internal32AtomicOps_Internalx86CPUFeaturesE
35 expected_static_init_count=2 35 # - _GLOBAL__I__ZN2v88internal8ThreadId18highest_thread_id_E
36 expected_static_init_count=3
36 37
37 v8_root=$(readlink -f $(dirname $BASH_SOURCE)/../) 38 v8_root=$(readlink -f $(dirname $BASH_SOURCE)/../)
38 39
39 if [ -n "$1" ] ; then 40 if [ -n "$1" ] ; then
40 d8="${v8_root}/$1" 41 d8="${v8_root}/$1"
41 else 42 else
42 d8="${v8_root}/d8" 43 d8="${v8_root}/d8"
43 fi 44 fi
44 45
45 if [ ! -f "$d8" ]; then 46 if [ ! -f "$d8" ]; then
46 echo "d8 binary not found: $d8" 47 echo "d8 binary not found: $d8"
47 exit 1 48 exit 1
48 fi 49 fi
49 50
50 static_inits=$(nm "$d8" | grep _GLOBAL_ | grep _I_ | awk '{ print $NF; }') 51 static_inits=$(nm "$d8" | grep _GLOBAL_ | grep _I_ | awk '{ print $NF; }')
51 52
52 static_init_count=$(echo "$static_inits" | wc -l) 53 static_init_count=$(echo "$static_inits" | wc -l)
53 54
54 if [ $static_init_count -gt $expected_static_init_count ]; then 55 if [ $static_init_count -gt $expected_static_init_count ]; then
55 echo "Too many static initializers." 56 echo "Too many static initializers."
56 echo "$static_inits" 57 echo "$static_inits"
57 exit 1 58 exit 1
58 else 59 else
59 echo "Static initializer check passed ($static_init_count initializers)." 60 echo "Static initializer check passed ($static_init_count initializers)."
60 exit 0 61 exit 0
61 fi 62 fi
OLDNEW
« no previous file with comments | « src/sampler.cc ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698