Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(4868)

Unified Diff: cc/resources/tile_manager.h

Issue 366113002: cc: Do not cleanup tiles with raster tasks. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: reset priority on correct tree. Created 6 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: cc/resources/tile_manager.h
diff --git a/cc/resources/tile_manager.h b/cc/resources/tile_manager.h
index 5ad80910f8e8aed434edc19e2a04571ce3d62781..235b5d4286cb7421532a071a3edc83d4de4ca301 100644
--- a/cc/resources/tile_manager.h
+++ b/cc/resources/tile_manager.h
@@ -227,7 +227,10 @@ class CC_EXPORT TileManager : public RasterizerClient,
void SetRasterizerForTesting(Rasterizer* rasterizer);
- void CleanUpReleasedTilesForTesting() { CleanUpReleasedTiles(); }
+ void FreeResourcesAndCleanUpReleasedTilesForTesting() {
+ FreeResourcesForReleasedTiles();
+ CleanUpReleasedTiles();
+ }
protected:
TileManager(TileManagerClient* client,
@@ -240,6 +243,7 @@ class CC_EXPORT TileManager : public RasterizerClient,
friend class Tile;
void DidChangeTilePriority(Tile* tile);
+ void FreeResourcesForReleasedTiles();
void CleanUpReleasedTiles();
// Overriden from RefCountedManager<Tile>:
@@ -324,6 +328,7 @@ class CC_EXPORT TileManager : public RasterizerClient,
RasterTaskCompletionStats update_visible_tiles_stats_;
+ // TODO(sohanjg): Use ScopedVector.
vmpstr 2014/07/25 16:29:25 Scoped vector would keep the tiles alive (thus pre
vmpstr 2014/07/25 16:43:43 Ignore this comment, I thought this was for priori
reveman 2014/07/25 17:00:55 This can't be a TODO. You're introducing a memory
sohanjg 2014/07/26 09:36:01 Done. yea.right!
std::vector<Tile*> released_tiles_;
ResourceFormat resource_format_;

Powered by Google App Engine
This is Rietveld 408576698