Index: cc/resources/tile_manager.cc |
diff --git a/cc/resources/tile_manager.cc b/cc/resources/tile_manager.cc |
index d508f6a0a17a5639290949fb9cf083eb4ffb6e10..91e932a39faa8e8ed849d2082bbaab2ee0314d7c 100644 |
--- a/cc/resources/tile_manager.cc |
+++ b/cc/resources/tile_manager.cc |
@@ -389,18 +389,17 @@ TileManager::~TileManager() { |
// our memory usage to drop to zero. |
global_state_ = GlobalStateThatImpactsTilePriority(); |
- CleanUpReleasedTiles(); |
- DCHECK_EQ(0u, tiles_.size()); |
reveman
2014/07/11 17:06:36
why remove this DCHECK? this is very useful. pleas
sohanjg
2014/07/12 11:41:59
Done.
|
- |
RasterTaskQueue empty; |
rasterizer_->ScheduleTasks(&empty); |
- orphan_raster_tasks_.clear(); |
// This should finish all pending tasks and release any uninitialized |
// resources. |
rasterizer_->Shutdown(); |
rasterizer_->CheckForCompletedTasks(); |
+ FreeResourcesForReleasedTiles(); |
+ CleanUpReleasedTiles(); |
+ |
DCHECK_EQ(0u, bytes_releasable_); |
DCHECK_EQ(0u, resources_releasable_); |
} |
@@ -418,16 +417,34 @@ bool TileManager::ShouldForceTasksRequiredForActivationToComplete() const { |
return global_state_.tree_priority != SMOOTHNESS_TAKES_PRIORITY; |
} |
-void TileManager::CleanUpReleasedTiles() { |
+void TileManager::FreeResourcesForReleasedTiles() { |
for (std::vector<Tile*>::iterator it = released_tiles_.begin(); |
it != released_tiles_.end(); |
++it) { |
Tile* tile = *it; |
- ManagedTileState& mts = tile->managed_state(); |
+ for (int mode = 0; mode < NUM_RASTER_MODES; ++mode) |
+ FreeResourceForTile(tile, static_cast<RasterMode>(mode)); |
+ } |
+} |
+bool TileManager::TileHasRasterTask(Tile* tile) { |
+ DCHECK(tile); |
reveman
2014/07/11 17:06:36
I don't think this DCHECK is useful. please remove
sohanjg
2014/07/12 11:41:59
Done.
|
+ ManagedTileState& mts = tile->managed_state(); |
+ bool tile_has_raster_task = false; |
reveman
2014/07/11 17:06:36
you don't need this variable
sohanjg
2014/07/12 11:41:58
Done.
|
for (int mode = 0; mode < NUM_RASTER_MODES; ++mode) { |
- FreeResourceForTile(tile, static_cast<RasterMode>(mode)); |
- orphan_raster_tasks_.push_back(mts.tile_versions[mode].raster_task_); |
+ if (mts.tile_versions[mode].raster_task_) |
+ tile_has_raster_task = true; |
reveman
2014/07/11 17:06:36
no need to iterate through all modes. just "return
sohanjg
2014/07/12 11:41:58
Done.
|
+ } |
+ return tile_has_raster_task; |
reveman
2014/07/11 17:06:36
and just "return false" here.
sohanjg
2014/07/12 11:41:59
Done.
|
+} |
+ |
+void TileManager::CleanUpReleasedTiles() { |
+ std::vector<Tile*>::iterator it = released_tiles_.begin(); |
+ while (it != released_tiles_.end()) { |
+ Tile* tile = *it; |
+ if (TileHasRasterTask(tile)) { |
reveman
2014/07/11 17:06:36
nit: I'd add a blank line before "if (TileHasR.."
sohanjg
2014/07/12 11:41:59
Done.
|
+ ++it; |
+ continue; |
} |
DCHECK(tiles_.find(tile->id()) != tiles_.end()); |
@@ -442,15 +459,15 @@ void TileManager::CleanUpReleasedTiles() { |
} |
delete tile; |
reveman
2014/07/11 17:06:36
please add a DCHECK(!tile->HasResources()) here so
sohanjg
2014/07/12 11:41:58
Done.
|
+ it = released_tiles_.erase(it); |
} |
- |
- released_tiles_.clear(); |
} |
void TileManager::UpdatePrioritizedTileSetIfNeeded() { |
if (!prioritized_tiles_dirty_) |
return; |
+ FreeResourcesForReleasedTiles(); |
CleanUpReleasedTiles(); |
prioritized_tiles_.Clear(); |
@@ -970,11 +987,6 @@ void TileManager::ScheduleTasks( |
// in |raster_tasks_|. |
rasterizer_->ScheduleTasks(&raster_queue_); |
- // It's now safe to clean up orphan tasks as raster worker pool is not |
- // allowed to keep around unreferenced raster tasks after ScheduleTasks() has |
- // been called. |
- orphan_raster_tasks_.clear(); |
- |
did_check_for_completed_tasks_since_last_schedule_tasks_ = false; |
} |
@@ -1069,17 +1081,12 @@ void TileManager::OnRasterTaskCompleted( |
const PicturePileImpl::Analysis& analysis, |
bool was_canceled) { |
TileMap::iterator it = tiles_.find(tile_id); |
- if (it == tiles_.end()) { |
- ++update_visible_tiles_stats_.canceled_count; |
- resource_pool_->ReleaseResource(resource.Pass()); |
- return; |
- } |
+ DCHECK(it != tiles_.end()); |
Tile* tile = it->second; |
ManagedTileState& mts = tile->managed_state(); |
ManagedTileState::TileVersion& tile_version = mts.tile_versions[raster_mode]; |
DCHECK(tile_version.raster_task_); |
- orphan_raster_tasks_.push_back(tile_version.raster_task_); |
tile_version.raster_task_ = NULL; |
if (was_canceled) { |