OLD | NEW |
---|---|
1 // Copyright 2012 The Chromium Authors. All rights reserved. | 1 // Copyright 2012 The Chromium Authors. All rights reserved. |
2 // Use of this source code is governed by a BSD-style license that can be | 2 // Use of this source code is governed by a BSD-style license that can be |
3 // found in the LICENSE file. | 3 // found in the LICENSE file. |
4 | 4 |
5 #include "cc/resources/tile_manager.h" | 5 #include "cc/resources/tile_manager.h" |
6 | 6 |
7 #include <algorithm> | 7 #include <algorithm> |
8 #include <limits> | 8 #include <limits> |
9 #include <string> | 9 #include <string> |
10 | 10 |
(...skipping 371 matching lines...) Expand 10 before | Expand all | Expand 10 after Loading... | |
382 base::Bind(&TileManager::CheckIfReadyToActivate, | 382 base::Bind(&TileManager::CheckIfReadyToActivate, |
383 base::Unretained(this))) { | 383 base::Unretained(this))) { |
384 rasterizer_->SetClient(this); | 384 rasterizer_->SetClient(this); |
385 } | 385 } |
386 | 386 |
387 TileManager::~TileManager() { | 387 TileManager::~TileManager() { |
388 // Reset global state and manage. This should cause | 388 // Reset global state and manage. This should cause |
389 // our memory usage to drop to zero. | 389 // our memory usage to drop to zero. |
390 global_state_ = GlobalStateThatImpactsTilePriority(); | 390 global_state_ = GlobalStateThatImpactsTilePriority(); |
391 | 391 |
392 CleanUpReleasedTiles(); | |
393 DCHECK_EQ(0u, tiles_.size()); | |
394 | |
395 RasterTaskQueue empty; | 392 RasterTaskQueue empty; |
396 rasterizer_->ScheduleTasks(&empty); | 393 rasterizer_->ScheduleTasks(&empty); |
397 orphan_raster_tasks_.clear(); | 394 orphan_raster_tasks_.clear(); |
398 | 395 |
399 // This should finish all pending tasks and release any uninitialized | 396 // This should finish all pending tasks and release any uninitialized |
400 // resources. | 397 // resources. |
401 rasterizer_->Shutdown(); | 398 rasterizer_->Shutdown(); |
402 rasterizer_->CheckForCompletedTasks(); | 399 rasterizer_->CheckForCompletedTasks(); |
403 | 400 |
401 FreeResourcesForReleasedTiles(); | |
402 CleanUpReleasedTiles(); | |
403 | |
404 DCHECK_EQ(0u, tiles_.size()); | |
404 DCHECK_EQ(0u, bytes_releasable_); | 405 DCHECK_EQ(0u, bytes_releasable_); |
405 DCHECK_EQ(0u, resources_releasable_); | 406 DCHECK_EQ(0u, resources_releasable_); |
406 } | 407 } |
407 | 408 |
408 void TileManager::Release(Tile* tile) { | 409 void TileManager::Release(Tile* tile) { |
410 // Reset priority as tile is ref-counted and might still be used | |
411 // even though we no longer hold a reference to it here anymore. | |
412 tile->SetPriority(ACTIVE_TREE, TilePriority()); | |
413 tile->SetPriority(PENDING_TREE, TilePriority()); | |
414 | |
409 prioritized_tiles_dirty_ = true; | 415 prioritized_tiles_dirty_ = true; |
410 released_tiles_.push_back(tile); | 416 released_tiles_.push_back(tile); |
411 } | 417 } |
412 | 418 |
413 void TileManager::DidChangeTilePriority(Tile* tile) { | 419 void TileManager::DidChangeTilePriority(Tile* tile) { |
414 prioritized_tiles_dirty_ = true; | 420 prioritized_tiles_dirty_ = true; |
415 } | 421 } |
416 | 422 |
417 bool TileManager::ShouldForceTasksRequiredForActivationToComplete() const { | 423 bool TileManager::ShouldForceTasksRequiredForActivationToComplete() const { |
418 return global_state_.tree_priority != SMOOTHNESS_TAKES_PRIORITY; | 424 return global_state_.tree_priority != SMOOTHNESS_TAKES_PRIORITY; |
419 } | 425 } |
420 | 426 |
421 void TileManager::CleanUpReleasedTiles() { | 427 void TileManager::FreeResourcesForReleasedTiles() { |
422 for (std::vector<Tile*>::iterator it = released_tiles_.begin(); | 428 for (std::vector<Tile*>::iterator it = released_tiles_.begin(); |
423 it != released_tiles_.end(); | 429 it != released_tiles_.end(); |
424 ++it) { | 430 ++it) { |
425 Tile* tile = *it; | 431 Tile* tile = *it; |
426 ManagedTileState& mts = tile->managed_state(); | 432 FreeResourcesForTile(tile); |
433 } | |
434 } | |
427 | 435 |
428 for (int mode = 0; mode < NUM_RASTER_MODES; ++mode) { | 436 void TileManager::CleanUpReleasedTiles() { |
429 FreeResourceForTile(tile, static_cast<RasterMode>(mode)); | 437 // TODO(sohanjg): Move it to UpdatePrioritizedTileSetIfNeeded. |
430 orphan_raster_tasks_.push_back(mts.tile_versions[mode].raster_task_); | 438 // Ensure that prioritized tile set has been build. |
439 DCHECK(prioritized_tiles_dirty_); | |
reveman
2014/07/23 16:26:54
Why did you remove this DCHECK? What was the reaso
sohanjg
2014/07/23 16:59:51
Well. the tests are not failing in my local debug
reveman
2014/07/23 17:08:48
The problem is the dtor where you might call this
| |
440 | |
441 std::vector<Tile*>::iterator it = released_tiles_.begin(); | |
442 while (it != released_tiles_.end()) { | |
443 Tile* tile = *it; | |
444 | |
445 if (tile->HasRasterTask()) { | |
446 ++it; | |
447 continue; | |
431 } | 448 } |
432 | 449 |
450 DCHECK(!tile->HasResources()); | |
433 DCHECK(tiles_.find(tile->id()) != tiles_.end()); | 451 DCHECK(tiles_.find(tile->id()) != tiles_.end()); |
434 tiles_.erase(tile->id()); | 452 tiles_.erase(tile->id()); |
435 | 453 |
436 LayerCountMap::iterator layer_it = | 454 LayerCountMap::iterator layer_it = |
437 used_layer_counts_.find(tile->layer_id()); | 455 used_layer_counts_.find(tile->layer_id()); |
438 DCHECK_GT(layer_it->second, 0); | 456 DCHECK_GT(layer_it->second, 0); |
439 if (--layer_it->second == 0) { | 457 if (--layer_it->second == 0) { |
440 used_layer_counts_.erase(layer_it); | 458 used_layer_counts_.erase(layer_it); |
441 image_decode_tasks_.erase(tile->layer_id()); | 459 image_decode_tasks_.erase(tile->layer_id()); |
442 } | 460 } |
443 | 461 |
444 delete tile; | 462 delete tile; |
463 it = released_tiles_.erase(it); | |
445 } | 464 } |
446 | |
447 released_tiles_.clear(); | |
448 } | 465 } |
449 | 466 |
450 void TileManager::UpdatePrioritizedTileSetIfNeeded() { | 467 void TileManager::UpdatePrioritizedTileSetIfNeeded() { |
451 if (!prioritized_tiles_dirty_) | 468 if (!prioritized_tiles_dirty_) |
452 return; | 469 return; |
453 | 470 |
471 FreeResourcesForReleasedTiles(); | |
454 CleanUpReleasedTiles(); | 472 CleanUpReleasedTiles(); |
455 | 473 |
456 prioritized_tiles_.Clear(); | 474 prioritized_tiles_.Clear(); |
457 GetTilesWithAssignedBins(&prioritized_tiles_); | 475 GetTilesWithAssignedBins(&prioritized_tiles_); |
458 prioritized_tiles_dirty_ = false; | 476 prioritized_tiles_dirty_ = false; |
459 } | 477 } |
460 | 478 |
461 void TileManager::DidFinishRunningTasks() { | 479 void TileManager::DidFinishRunningTasks() { |
462 TRACE_EVENT0("cc", "TileManager::DidFinishRunningTasks"); | 480 TRACE_EVENT0("cc", "TileManager::DidFinishRunningTasks"); |
463 | 481 |
(...skipping 13 matching lines...) Expand all Loading... | |
477 AssignGpuMemoryToTiles(&prioritized_tiles_, | 495 AssignGpuMemoryToTiles(&prioritized_tiles_, |
478 &tiles_that_need_to_be_rasterized); | 496 &tiles_that_need_to_be_rasterized); |
479 | 497 |
480 // |tiles_that_need_to_be_rasterized| will be empty when we reach a | 498 // |tiles_that_need_to_be_rasterized| will be empty when we reach a |
481 // steady memory state. Keep scheduling tasks until we reach this state. | 499 // steady memory state. Keep scheduling tasks until we reach this state. |
482 if (!tiles_that_need_to_be_rasterized.empty()) { | 500 if (!tiles_that_need_to_be_rasterized.empty()) { |
483 ScheduleTasks(tiles_that_need_to_be_rasterized); | 501 ScheduleTasks(tiles_that_need_to_be_rasterized); |
484 return; | 502 return; |
485 } | 503 } |
486 | 504 |
505 FreeResourcesForReleasedTiles(); | |
506 | |
487 resource_pool_->ReduceResourceUsage(); | 507 resource_pool_->ReduceResourceUsage(); |
488 | 508 |
489 // We don't reserve memory for required-for-activation tiles during | 509 // We don't reserve memory for required-for-activation tiles during |
490 // accelerated gestures, so we just postpone activation when we don't | 510 // accelerated gestures, so we just postpone activation when we don't |
491 // have these tiles, and activate after the accelerated gesture. | 511 // have these tiles, and activate after the accelerated gesture. |
492 bool allow_rasterize_on_demand = | 512 bool allow_rasterize_on_demand = |
493 global_state_.tree_priority != SMOOTHNESS_TAKES_PRIORITY; | 513 global_state_.tree_priority != SMOOTHNESS_TAKES_PRIORITY; |
494 | 514 |
495 // Use on-demand raster for any required-for-activation tiles that have not | 515 // Use on-demand raster for any required-for-activation tiles that have not |
496 // been been assigned memory after reaching a steady memory state. This | 516 // been been assigned memory after reaching a steady memory state. This |
(...skipping 567 matching lines...) Expand 10 before | Expand all | Expand 10 after Loading... | |
1064 if (task_it != pixel_ref_tasks.end()) | 1084 if (task_it != pixel_ref_tasks.end()) |
1065 pixel_ref_tasks.erase(task_it); | 1085 pixel_ref_tasks.erase(task_it); |
1066 } | 1086 } |
1067 | 1087 |
1068 void TileManager::OnRasterTaskCompleted( | 1088 void TileManager::OnRasterTaskCompleted( |
1069 Tile::Id tile_id, | 1089 Tile::Id tile_id, |
1070 scoped_ptr<ScopedResource> resource, | 1090 scoped_ptr<ScopedResource> resource, |
1071 RasterMode raster_mode, | 1091 RasterMode raster_mode, |
1072 const PicturePileImpl::Analysis& analysis, | 1092 const PicturePileImpl::Analysis& analysis, |
1073 bool was_canceled) { | 1093 bool was_canceled) { |
1074 TileMap::iterator it = tiles_.find(tile_id); | 1094 DCHECK(tiles_.find(tile_id) != tiles_.end()); |
1075 if (it == tiles_.end()) { | |
1076 ++update_visible_tiles_stats_.canceled_count; | |
1077 resource_pool_->ReleaseResource(resource.Pass()); | |
1078 return; | |
1079 } | |
1080 | 1095 |
1081 Tile* tile = it->second; | 1096 Tile* tile = tiles_[tile_id]; |
1082 ManagedTileState& mts = tile->managed_state(); | 1097 ManagedTileState& mts = tile->managed_state(); |
1083 ManagedTileState::TileVersion& tile_version = mts.tile_versions[raster_mode]; | 1098 ManagedTileState::TileVersion& tile_version = mts.tile_versions[raster_mode]; |
1084 DCHECK(tile_version.raster_task_); | 1099 DCHECK(tile_version.raster_task_); |
1085 orphan_raster_tasks_.push_back(tile_version.raster_task_); | 1100 orphan_raster_tasks_.push_back(tile_version.raster_task_); |
1086 tile_version.raster_task_ = NULL; | 1101 tile_version.raster_task_ = NULL; |
1087 | 1102 |
1088 if (was_canceled) { | 1103 if (was_canceled) { |
1089 ++update_visible_tiles_stats_.canceled_count; | 1104 ++update_visible_tiles_stats_.canceled_count; |
1090 resource_pool_->ReleaseResource(resource.Pass()); | 1105 resource_pool_->ReleaseResource(resource.Pass()); |
1091 return; | 1106 return; |
(...skipping 501 matching lines...) Expand 10 before | Expand all | Expand 10 after Loading... | |
1593 TRACE_EVENT0("cc", "TileManager::CheckIfReadyToActivate"); | 1608 TRACE_EVENT0("cc", "TileManager::CheckIfReadyToActivate"); |
1594 | 1609 |
1595 rasterizer_->CheckForCompletedTasks(); | 1610 rasterizer_->CheckForCompletedTasks(); |
1596 did_check_for_completed_tasks_since_last_schedule_tasks_ = true; | 1611 did_check_for_completed_tasks_since_last_schedule_tasks_ = true; |
1597 | 1612 |
1598 if (IsReadyToActivate()) | 1613 if (IsReadyToActivate()) |
1599 client_->NotifyReadyToActivate(); | 1614 client_->NotifyReadyToActivate(); |
1600 } | 1615 } |
1601 | 1616 |
1602 } // namespace cc | 1617 } // namespace cc |
OLD | NEW |