Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(368)

Issue 366073002: [fsp] Check for modification time in the file stream reader. (Closed)

Created:
6 years, 5 months ago by mtomasz
Modified:
6 years, 5 months ago
Reviewers:
kinaba
CC:
chromium-reviews, nkostylev+watch_chromium.org, tzik, nhiroki, oshima+watch_chromium.org, stevenjb+watch_chromium.org, kinuko+fileapi, davemoore+watch_chromium.org
Project:
chromium
Visibility:
Public.

Description

[fsp] Check for modification time in the file stream reader. According to the FileStreamReader interface, we have to check the modification time if it is the same as the expected one. Note, that we can provide a better file integration mechanisms within providing extensions. TEST=unit_tests: *FileSystemProviderFileStreamReader*Modif* BUG=248427 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=281247

Patch Set 1 #

Patch Set 2 : Added more tests. #

Total comments: 2

Patch Set 3 : Fixed. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+215 lines, -64 lines) Patch
M chrome/browser/chromeos/file_system_provider/fake_provided_file_system.h View 1 chunk +1 line, -0 lines 0 comments Download
M chrome/browser/chromeos/file_system_provider/fake_provided_file_system.cc View 2 chunks +3 lines, -2 lines 0 comments Download
M chrome/browser/chromeos/file_system_provider/fileapi/file_stream_reader.h View 5 chunks +13 lines, -3 lines 0 comments Download
M chrome/browser/chromeos/file_system_provider/fileapi/file_stream_reader.cc View 1 2 14 chunks +107 lines, -31 lines 0 comments Download
M chrome/browser/chromeos/file_system_provider/fileapi/file_stream_reader_unittest.cc View 1 9 chunks +91 lines, -28 lines 0 comments Download

Messages

Total messages: 6 (0 generated)
mtomasz
@kinaba: PTAL. Thanks.
6 years, 5 months ago (2014-07-03 07:31:02 UTC) #1
kinaba
lgtm https://codereview.chromium.org/366073002/diff/20001/chrome/browser/chromeos/file_system_provider/fileapi/file_stream_reader.cc File chrome/browser/chromeos/file_system_provider/fileapi/file_stream_reader.cc (right): https://codereview.chromium.org/366073002/diff/20001/chrome/browser/chromeos/file_system_provider/fileapi/file_stream_reader.cc#newcode244 chrome/browser/chromeos/file_system_provider/fileapi/file_stream_reader.cc:244: DCHECK_EQ(result, base::File::FILE_OK); Maybe: DCHECK_EQ(base::File::FILE_OK, result); since in other ...
6 years, 5 months ago (2014-07-03 07:40:17 UTC) #2
mtomasz
https://codereview.chromium.org/366073002/diff/20001/chrome/browser/chromeos/file_system_provider/fileapi/file_stream_reader.cc File chrome/browser/chromeos/file_system_provider/fileapi/file_stream_reader.cc (right): https://codereview.chromium.org/366073002/diff/20001/chrome/browser/chromeos/file_system_provider/fileapi/file_stream_reader.cc#newcode244 chrome/browser/chromeos/file_system_provider/fileapi/file_stream_reader.cc:244: DCHECK_EQ(result, base::File::FILE_OK); On 2014/07/03 07:40:17, kinaba wrote: > Maybe: ...
6 years, 5 months ago (2014-07-03 07:44:42 UTC) #3
mtomasz
The CQ bit was checked by mtomasz@chromium.org
6 years, 5 months ago (2014-07-03 07:44:46 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/mtomasz@chromium.org/366073002/40001
6 years, 5 months ago (2014-07-03 07:45:28 UTC) #5
commit-bot: I haz the power
6 years, 5 months ago (2014-07-03 12:28:00 UTC) #6
Message was sent while issue was closed.
Change committed as 281247

Powered by Google App Engine
This is Rietveld 408576698