Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(339)

Issue 366018: Create new baselines for the ruby tests.... (Closed)

Created:
11 years, 1 month ago by dglazkov
Modified:
9 years, 6 months ago
Reviewers:
hamaji
CC:
chromium-reviews_googlegroups.com, darin (slow to review), pam+watch_chromium.org
Base URL:
svn://chrome-svn.corp.google.com/chrome/trunk/src/
Visibility:
Public.

Description

Create new baselines for the ruby tests. Test were added in http://trac.webkit.org/changeset/50495. R=hamaji TEST=none BUG=20206 Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=31041

Patch Set 1 #

Patch Set 2 : Cleaned up left-over strings in test_expectations. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1371 lines, -20 lines) Patch
A webkit/data/layout_tests/platform/chromium-linux/LayoutTests/fast/ruby/ruby-empty-rt-expected.checksum View 1 chunk +1 line, -0 lines 0 comments Download
A webkit/data/layout_tests/platform/chromium-linux/LayoutTests/fast/ruby/ruby-empty-rt-expected.png View Binary file 0 comments Download
A webkit/data/layout_tests/platform/chromium-linux/LayoutTests/fast/ruby/ruby-empty-rt-expected.txt View 1 chunk +37 lines, -0 lines 0 comments Download
A webkit/data/layout_tests/platform/chromium-linux/LayoutTests/fast/ruby/ruby-length-expected.checksum View 1 chunk +1 line, -0 lines 0 comments Download
A webkit/data/layout_tests/platform/chromium-linux/LayoutTests/fast/ruby/ruby-length-expected.png View Binary file 0 comments Download
A webkit/data/layout_tests/platform/chromium-linux/LayoutTests/fast/ruby/ruby-length-expected.txt View 1 chunk +33 lines, -0 lines 0 comments Download
A webkit/data/layout_tests/platform/chromium-linux/LayoutTests/fast/ruby/ruby-run-break-expected.checksum View 1 chunk +1 line, -0 lines 0 comments Download
A webkit/data/layout_tests/platform/chromium-linux/LayoutTests/fast/ruby/ruby-run-break-expected.png View Binary file 0 comments Download
A webkit/data/layout_tests/platform/chromium-linux/LayoutTests/fast/ruby/ruby-run-break-expected.txt View 1 chunk +40 lines, -0 lines 0 comments Download
A webkit/data/layout_tests/platform/chromium-linux/LayoutTests/fast/ruby/ruby-runs-expected.checksum View 1 chunk +1 line, -0 lines 0 comments Download
A webkit/data/layout_tests/platform/chromium-linux/LayoutTests/fast/ruby/ruby-runs-expected.png View Binary file 0 comments Download
A webkit/data/layout_tests/platform/chromium-linux/LayoutTests/fast/ruby/ruby-runs-expected.txt View 1 chunk +36 lines, -0 lines 0 comments Download
A webkit/data/layout_tests/platform/chromium-linux/LayoutTests/fast/ruby/ruby-runs-spans-expected.checksum View 1 chunk +1 line, -0 lines 0 comments Download
A webkit/data/layout_tests/platform/chromium-linux/LayoutTests/fast/ruby/ruby-runs-spans-expected.png View Binary file 0 comments Download
A webkit/data/layout_tests/platform/chromium-linux/LayoutTests/fast/ruby/ruby-runs-spans-expected.txt View 1 chunk +35 lines, -0 lines 0 comments Download
A webkit/data/layout_tests/platform/chromium-linux/LayoutTests/fast/ruby/ruby-simple-expected.checksum View 1 chunk +1 line, -0 lines 0 comments Download
A webkit/data/layout_tests/platform/chromium-linux/LayoutTests/fast/ruby/ruby-simple-expected.png View Binary file 0 comments Download
A webkit/data/layout_tests/platform/chromium-linux/LayoutTests/fast/ruby/ruby-simple-expected.txt View 1 chunk +22 lines, -0 lines 0 comments Download
A webkit/data/layout_tests/platform/chromium-linux/LayoutTests/fast/ruby/ruby-simple-rp-expected.checksum View 1 chunk +1 line, -0 lines 0 comments Download
A webkit/data/layout_tests/platform/chromium-linux/LayoutTests/fast/ruby/ruby-simple-rp-expected.png View Binary file 0 comments Download
A webkit/data/layout_tests/platform/chromium-linux/LayoutTests/fast/ruby/ruby-simple-rp-expected.txt View 1 chunk +24 lines, -0 lines 0 comments Download
A webkit/data/layout_tests/platform/chromium-linux/LayoutTests/fast/ruby/ruby-trailing-expected.checksum View 1 chunk +1 line, -0 lines 0 comments Download
A webkit/data/layout_tests/platform/chromium-linux/LayoutTests/fast/ruby/ruby-trailing-expected.png View Binary file 0 comments Download
A webkit/data/layout_tests/platform/chromium-linux/LayoutTests/fast/ruby/ruby-trailing-expected.txt View 1 chunk +37 lines, -0 lines 0 comments Download
A webkit/data/layout_tests/platform/chromium-linux/LayoutTests/fast/ruby/rubyDOM-insert-rt-expected.checksum View 1 chunk +1 line, -0 lines 0 comments Download
A webkit/data/layout_tests/platform/chromium-linux/LayoutTests/fast/ruby/rubyDOM-insert-rt-expected.png View Binary file 0 comments Download
A webkit/data/layout_tests/platform/chromium-linux/LayoutTests/fast/ruby/rubyDOM-insert-rt-expected.txt View 1 chunk +74 lines, -0 lines 0 comments Download
A webkit/data/layout_tests/platform/chromium-linux/LayoutTests/fast/ruby/rubyDOM-insert-text1-expected.checksum View 1 chunk +1 line, -0 lines 0 comments Download
A webkit/data/layout_tests/platform/chromium-linux/LayoutTests/fast/ruby/rubyDOM-insert-text1-expected.png View Binary file 0 comments Download
A webkit/data/layout_tests/platform/chromium-linux/LayoutTests/fast/ruby/rubyDOM-insert-text1-expected.txt View 1 chunk +72 lines, -0 lines 0 comments Download
A webkit/data/layout_tests/platform/chromium-linux/LayoutTests/fast/ruby/rubyDOM-insert-text2-expected.checksum View 1 chunk +1 line, -0 lines 0 comments Download
A webkit/data/layout_tests/platform/chromium-linux/LayoutTests/fast/ruby/rubyDOM-insert-text2-expected.png View Binary file 0 comments Download
A webkit/data/layout_tests/platform/chromium-linux/LayoutTests/fast/ruby/rubyDOM-insert-text2-expected.txt View 1 chunk +46 lines, -0 lines 0 comments Download
A webkit/data/layout_tests/platform/chromium-linux/LayoutTests/fast/ruby/rubyDOM-insert-text3-expected.checksum View 1 chunk +1 line, -0 lines 0 comments Download
A webkit/data/layout_tests/platform/chromium-linux/LayoutTests/fast/ruby/rubyDOM-insert-text3-expected.png View Binary file 0 comments Download
A webkit/data/layout_tests/platform/chromium-linux/LayoutTests/fast/ruby/rubyDOM-insert-text3-expected.txt View 1 chunk +46 lines, -0 lines 0 comments Download
A webkit/data/layout_tests/platform/chromium-linux/LayoutTests/fast/ruby/rubyDOM-remove-rt1-expected.checksum View 1 chunk +1 line, -0 lines 0 comments Download
A webkit/data/layout_tests/platform/chromium-linux/LayoutTests/fast/ruby/rubyDOM-remove-rt1-expected.png View Binary file 0 comments Download
A webkit/data/layout_tests/platform/chromium-linux/LayoutTests/fast/ruby/rubyDOM-remove-rt1-expected.txt View 1 chunk +48 lines, -0 lines 0 comments Download
A webkit/data/layout_tests/platform/chromium-linux/LayoutTests/fast/ruby/rubyDOM-remove-rt2-expected.checksum View 1 chunk +1 line, -0 lines 0 comments Download
A webkit/data/layout_tests/platform/chromium-linux/LayoutTests/fast/ruby/rubyDOM-remove-rt2-expected.png View Binary file 0 comments Download
A webkit/data/layout_tests/platform/chromium-linux/LayoutTests/fast/ruby/rubyDOM-remove-rt2-expected.txt View 1 chunk +42 lines, -0 lines 0 comments Download
A webkit/data/layout_tests/platform/chromium-linux/LayoutTests/fast/ruby/rubyDOM-remove-text1-expected.checksum View 1 chunk +1 line, -0 lines 0 comments Download
A webkit/data/layout_tests/platform/chromium-linux/LayoutTests/fast/ruby/rubyDOM-remove-text1-expected.png View Binary file 0 comments Download
A webkit/data/layout_tests/platform/chromium-linux/LayoutTests/fast/ruby/rubyDOM-remove-text1-expected.txt View 1 chunk +42 lines, -0 lines 0 comments Download
A webkit/data/layout_tests/platform/chromium-linux/LayoutTests/fast/ruby/rubyDOM-remove-text2-expected.checksum View 1 chunk +1 line, -0 lines 0 comments Download
A webkit/data/layout_tests/platform/chromium-linux/LayoutTests/fast/ruby/rubyDOM-remove-text2-expected.png View Binary file 0 comments Download
A webkit/data/layout_tests/platform/chromium-linux/LayoutTests/fast/ruby/rubyDOM-remove-text2-expected.txt View 1 chunk +35 lines, -0 lines 0 comments Download
A webkit/data/layout_tests/platform/chromium-win/LayoutTests/fast/ruby/ruby-empty-rt-expected.checksum View 1 chunk +1 line, -0 lines 0 comments Download
A webkit/data/layout_tests/platform/chromium-win/LayoutTests/fast/ruby/ruby-empty-rt-expected.png View Binary file 0 comments Download
A webkit/data/layout_tests/platform/chromium-win/LayoutTests/fast/ruby/ruby-empty-rt-expected.txt View 1 chunk +37 lines, -0 lines 0 comments Download
A webkit/data/layout_tests/platform/chromium-win/LayoutTests/fast/ruby/ruby-length-expected.checksum View 1 chunk +1 line, -0 lines 0 comments Download
A webkit/data/layout_tests/platform/chromium-win/LayoutTests/fast/ruby/ruby-length-expected.png View Binary file 0 comments Download
A webkit/data/layout_tests/platform/chromium-win/LayoutTests/fast/ruby/ruby-length-expected.txt View 1 chunk +33 lines, -0 lines 0 comments Download
A webkit/data/layout_tests/platform/chromium-win/LayoutTests/fast/ruby/ruby-run-break-expected.checksum View 1 chunk +1 line, -0 lines 0 comments Download
A webkit/data/layout_tests/platform/chromium-win/LayoutTests/fast/ruby/ruby-run-break-expected.png View Binary file 0 comments Download
A webkit/data/layout_tests/platform/chromium-win/LayoutTests/fast/ruby/ruby-run-break-expected.txt View 1 chunk +40 lines, -0 lines 0 comments Download
A webkit/data/layout_tests/platform/chromium-win/LayoutTests/fast/ruby/ruby-runs-expected.checksum View 1 chunk +1 line, -0 lines 0 comments Download
A webkit/data/layout_tests/platform/chromium-win/LayoutTests/fast/ruby/ruby-runs-expected.png View Binary file 0 comments Download
A webkit/data/layout_tests/platform/chromium-win/LayoutTests/fast/ruby/ruby-runs-expected.txt View 1 chunk +36 lines, -0 lines 0 comments Download
A webkit/data/layout_tests/platform/chromium-win/LayoutTests/fast/ruby/ruby-runs-spans-expected.checksum View 1 chunk +1 line, -0 lines 0 comments Download
A webkit/data/layout_tests/platform/chromium-win/LayoutTests/fast/ruby/ruby-runs-spans-expected.png View Binary file 0 comments Download
A webkit/data/layout_tests/platform/chromium-win/LayoutTests/fast/ruby/ruby-runs-spans-expected.txt View 1 chunk +35 lines, -0 lines 0 comments Download
A webkit/data/layout_tests/platform/chromium-win/LayoutTests/fast/ruby/ruby-simple-expected.checksum View 1 chunk +1 line, -0 lines 0 comments Download
A webkit/data/layout_tests/platform/chromium-win/LayoutTests/fast/ruby/ruby-simple-expected.png View Binary file 0 comments Download
A webkit/data/layout_tests/platform/chromium-win/LayoutTests/fast/ruby/ruby-simple-expected.txt View 1 chunk +22 lines, -0 lines 0 comments Download
A webkit/data/layout_tests/platform/chromium-win/LayoutTests/fast/ruby/ruby-simple-rp-expected.checksum View 1 chunk +1 line, -0 lines 0 comments Download
A webkit/data/layout_tests/platform/chromium-win/LayoutTests/fast/ruby/ruby-simple-rp-expected.png View Binary file 0 comments Download
A webkit/data/layout_tests/platform/chromium-win/LayoutTests/fast/ruby/ruby-simple-rp-expected.txt View 1 chunk +24 lines, -0 lines 0 comments Download
A webkit/data/layout_tests/platform/chromium-win/LayoutTests/fast/ruby/ruby-trailing-expected.checksum View 1 chunk +1 line, -0 lines 0 comments Download
A webkit/data/layout_tests/platform/chromium-win/LayoutTests/fast/ruby/ruby-trailing-expected.png View Binary file 0 comments Download
A webkit/data/layout_tests/platform/chromium-win/LayoutTests/fast/ruby/ruby-trailing-expected.txt View 1 chunk +37 lines, -0 lines 0 comments Download
A webkit/data/layout_tests/platform/chromium-win/LayoutTests/fast/ruby/rubyDOM-insert-rt-expected.checksum View 1 chunk +1 line, -0 lines 0 comments Download
A webkit/data/layout_tests/platform/chromium-win/LayoutTests/fast/ruby/rubyDOM-insert-rt-expected.png View Binary file 0 comments Download
A webkit/data/layout_tests/platform/chromium-win/LayoutTests/fast/ruby/rubyDOM-insert-rt-expected.txt View 1 chunk +74 lines, -0 lines 0 comments Download
A webkit/data/layout_tests/platform/chromium-win/LayoutTests/fast/ruby/rubyDOM-insert-text1-expected.checksum View 1 chunk +1 line, -0 lines 0 comments Download
A webkit/data/layout_tests/platform/chromium-win/LayoutTests/fast/ruby/rubyDOM-insert-text1-expected.png View Binary file 0 comments Download
A webkit/data/layout_tests/platform/chromium-win/LayoutTests/fast/ruby/rubyDOM-insert-text1-expected.txt View 1 chunk +72 lines, -0 lines 0 comments Download
A webkit/data/layout_tests/platform/chromium-win/LayoutTests/fast/ruby/rubyDOM-insert-text2-expected.checksum View 1 chunk +1 line, -0 lines 0 comments Download
A webkit/data/layout_tests/platform/chromium-win/LayoutTests/fast/ruby/rubyDOM-insert-text2-expected.png View Binary file 0 comments Download
A webkit/data/layout_tests/platform/chromium-win/LayoutTests/fast/ruby/rubyDOM-insert-text2-expected.txt View 1 chunk +46 lines, -0 lines 0 comments Download
A webkit/data/layout_tests/platform/chromium-win/LayoutTests/fast/ruby/rubyDOM-insert-text3-expected.checksum View 1 chunk +1 line, -0 lines 0 comments Download
A webkit/data/layout_tests/platform/chromium-win/LayoutTests/fast/ruby/rubyDOM-insert-text3-expected.png View Binary file 0 comments Download
A webkit/data/layout_tests/platform/chromium-win/LayoutTests/fast/ruby/rubyDOM-insert-text3-expected.txt View 1 chunk +46 lines, -0 lines 0 comments Download
A webkit/data/layout_tests/platform/chromium-win/LayoutTests/fast/ruby/rubyDOM-remove-rt1-expected.checksum View 1 chunk +1 line, -0 lines 0 comments Download
A webkit/data/layout_tests/platform/chromium-win/LayoutTests/fast/ruby/rubyDOM-remove-rt1-expected.png View Binary file 0 comments Download
A webkit/data/layout_tests/platform/chromium-win/LayoutTests/fast/ruby/rubyDOM-remove-rt1-expected.txt View 1 chunk +48 lines, -0 lines 0 comments Download
A webkit/data/layout_tests/platform/chromium-win/LayoutTests/fast/ruby/rubyDOM-remove-rt2-expected.checksum View 1 chunk +1 line, -0 lines 0 comments Download
A webkit/data/layout_tests/platform/chromium-win/LayoutTests/fast/ruby/rubyDOM-remove-rt2-expected.png View Binary file 0 comments Download
A webkit/data/layout_tests/platform/chromium-win/LayoutTests/fast/ruby/rubyDOM-remove-rt2-expected.txt View 1 chunk +42 lines, -0 lines 0 comments Download
A webkit/data/layout_tests/platform/chromium-win/LayoutTests/fast/ruby/rubyDOM-remove-text1-expected.checksum View 1 chunk +1 line, -0 lines 0 comments Download
A webkit/data/layout_tests/platform/chromium-win/LayoutTests/fast/ruby/rubyDOM-remove-text1-expected.png View Binary file 0 comments Download
A webkit/data/layout_tests/platform/chromium-win/LayoutTests/fast/ruby/rubyDOM-remove-text1-expected.txt View 1 chunk +42 lines, -0 lines 0 comments Download
A webkit/data/layout_tests/platform/chromium-win/LayoutTests/fast/ruby/rubyDOM-remove-text2-expected.checksum View 1 chunk +1 line, -0 lines 0 comments Download
A webkit/data/layout_tests/platform/chromium-win/LayoutTests/fast/ruby/rubyDOM-remove-text2-expected.png View Binary file 0 comments Download
A webkit/data/layout_tests/platform/chromium-win/LayoutTests/fast/ruby/rubyDOM-remove-text2-expected.txt View 1 chunk +35 lines, -0 lines 0 comments Download
M webkit/tools/layout_tests/test_expectations.txt View 1 1 chunk +1 line, -20 lines 0 comments Download

Messages

Total messages: 3 (0 generated)
dglazkov
11 years, 1 month ago (2009-11-04 23:49:47 UTC) #1
dglazkov
This is essentially a re-do of Roland's http://codereview.chromium.org/173347.
11 years, 1 month ago (2009-11-04 23:51:01 UTC) #2
hamaji
11 years, 1 month ago (2009-11-04 23:59:13 UTC) #3
LGTM.

I believe the following test case could be improved because intention of the
test is not so clear. But it's the issue of upstream, LGTM as a rebaseline
change.

http://codereview.chromium.org/366018/diff/1/22

Powered by Google App Engine
This is Rietveld 408576698