Issue 3660010: Reland fix for OCSP startup race.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 3660010: Reland fix for OCSP startup race. (Closed)

Created:
10 years, 2 months ago by willchan no longer on Chromium

Modified:
9 years, 7 months ago

Reviewers:

CC:
chromium-reviews, cbentzel+watch_chromium.org, darin-cc_chromium.org, ben+cc_chromium.org

Base URL:
http://git.chromium.org/git/chromium.git

Visibility:
Public.

Description

Reland fix for OCSP startup race. This is a revert of r62107 which is a revert of r62105 which is a revert of r60753 which is a revert of r60739 which is a revert of r60025 which is a revert of r59972 which is a revert of r59570 which is a revert of r59511 which is a revert of r59299 which is a revert of r59289. The most recent reverts have all been due to ChromiumOS leaks which I believe to be fixed after fixing bug 58572, since I tested the combined fix in r62105 which was green on all ChromiumOS valgrind bots. BUG=55940 TEST=Run a debug build on Linux. 10% or so of startups used to crash on startup. Shouldn't happen anymore. Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=62256

Patch Set 1 #

Created: 10 years, 2 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+223 lines, -103 lines)			Patch
M	chrome/browser/io_thread.cc	View	2 chunks	+9 lines, -0 lines	0 comments	Download
M	chrome/browser/net/chrome_url_request_context.h	View	1 chunk	+0 lines, -1 line	0 comments	Download
M	chrome/browser/net/chrome_url_request_context.cc	View	3 chunks	+10 lines, -6 lines	0 comments	Download
M	chrome/browser/profile_impl.cc	View	1 chunk	+1 line, -0 lines	0 comments	Download
M	chrome/common/net/url_request_context_getter.h	View	3 chunks	+14 lines, -1 line	0 comments	Download
M	chrome/common/net/url_request_context_getter.cc	View	2 chunks	+1 line, -2 lines	0 comments	Download
M	net/ocsp/nss_ocsp.h	View	1 chunk	+5 lines, -0 lines	0 comments	Download
M	net/ocsp/nss_ocsp.cc	View	7 chunks	+172 lines, -92 lines	0 comments	Download
M	net/proxy/proxy_script_fetcher.cc	View	1 chunk	+1 line, -0 lines	0 comments	Download
M	net/url_request/url_request_context.h	View	2 chunks	+8 lines, -0 lines	0 comments	Download
M	net/url_request/url_request_context.cc	View	1 chunk	+2 lines, -1 line	0 comments	Download