Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(261)

Issue 365983004: Add a new safe browsing incident reporting service unit test. (Closed)

Created:
6 years, 5 months ago by grt (UTC plus 2)
Modified:
6 years, 5 months ago
Reviewers:
mattm
CC:
chromium-reviews
Project:
chromium
Visibility:
Public.

Description

Add a new safe browsing incident reporting service unit test. This test confirms that incidents are coalesced into a report properly. BUG=none R=mattm@chromium.org Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=281921

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+42 lines, -12 lines) Patch
M chrome/browser/safe_browsing/incident_reporting_service_unittest.cc View 8 chunks +42 lines, -12 lines 0 comments Download

Messages

Total messages: 5 (0 generated)
grt (UTC plus 2)
PTAL.
6 years, 5 months ago (2014-07-04 18:54:07 UTC) #1
mattm
lgtm
6 years, 5 months ago (2014-07-08 20:38:21 UTC) #2
grt (UTC plus 2)
The CQ bit was checked by grt@chromium.org
6 years, 5 months ago (2014-07-08 20:49:06 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/grt@chromium.org/365983004/1
6 years, 5 months ago (2014-07-08 20:51:51 UTC) #4
commit-bot: I haz the power
6 years, 5 months ago (2014-07-09 04:15:02 UTC) #5
Message was sent while issue was closed.
Change committed as 281921

Powered by Google App Engine
This is Rietveld 408576698