Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(135)

Side by Side Diff: runtime/vm/instructions_arm64_test.cc

Issue 365983002: Make isolate specific stub code accessors instance methods instead (Closed) Base URL: http://dart.googlecode.com/svn/branches/bleeding_edge/dart/
Patch Set: Created 6 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
« no previous file with comments | « runtime/vm/flow_graph_compiler_x64.cc ('k') | runtime/vm/instructions_arm_test.cc » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright (c) 2014, the Dart project authors. Please see the AUTHORS file 1 // Copyright (c) 2014, the Dart project authors. Please see the AUTHORS file
2 // for details. All rights reserved. Use of this source code is governed by a 2 // for details. All rights reserved. Use of this source code is governed by a
3 // BSD-style license that can be found in the LICENSE file. 3 // BSD-style license that can be found in the LICENSE file.
4 4
5 #include "vm/globals.h" 5 #include "vm/globals.h"
6 #if defined(TARGET_ARCH_ARM64) 6 #if defined(TARGET_ARCH_ARM64)
7 7
8 #include "vm/assembler.h" 8 #include "vm/assembler.h"
9 #include "vm/cpu.h" 9 #include "vm/cpu.h"
10 #include "vm/instructions.h" 10 #include "vm/instructions.h"
11 #include "vm/stub_code.h" 11 #include "vm/stub_code.h"
12 #include "vm/unit_test.h" 12 #include "vm/unit_test.h"
13 13
14 namespace dart { 14 namespace dart {
15 15
16 #define __ assembler-> 16 #define __ assembler->
17 17
18 ASSEMBLER_TEST_GENERATE(Call, assembler) { 18 ASSEMBLER_TEST_GENERATE(Call, assembler) {
19 __ BranchLinkPatchable(&StubCode::InvokeDartCodeLabel()); 19 StubCode* stub_code = Isolate::Current()->stub_code();
20 __ BranchLinkPatchable(&stub_code->InvokeDartCodeLabel());
20 __ ret(); 21 __ ret();
21 } 22 }
22 23
23 24
24 ASSEMBLER_TEST_RUN(Call, test) { 25 ASSEMBLER_TEST_RUN(Call, test) {
25 // The return address, which must be the address of an instruction contained 26 // The return address, which must be the address of an instruction contained
26 // in the code, points to the Ret instruction above, i.e. one instruction 27 // in the code, points to the Ret instruction above, i.e. one instruction
27 // before the end of the code buffer. 28 // before the end of the code buffer.
28 CallPattern call(test->entry() + test->code().Size() - Instr::kInstrSize, 29 CallPattern call(test->entry() + test->code().Size() - Instr::kInstrSize,
29 test->code()); 30 test->code());
30 EXPECT_EQ(StubCode::InvokeDartCodeLabel().address(), 31 StubCode* stub_code = Isolate::Current()->stub_code();
32 EXPECT_EQ(stub_code->InvokeDartCodeLabel().address(),
31 call.TargetAddress()); 33 call.TargetAddress());
32 } 34 }
33 35
34 36
35 ASSEMBLER_TEST_GENERATE(Jump, assembler) { 37 ASSEMBLER_TEST_GENERATE(Jump, assembler) {
36 __ BranchPatchable(&StubCode::InvokeDartCodeLabel()); 38 StubCode* stub_code = Isolate::Current()->stub_code();
37 __ BranchPatchable(&StubCode::AllocateArrayLabel()); 39 __ BranchPatchable(&stub_code->InvokeDartCodeLabel());
40 __ BranchPatchable(&stub_code->AllocateArrayLabel());
38 } 41 }
39 42
40 43
41 ASSEMBLER_TEST_RUN(Jump, test) { 44 ASSEMBLER_TEST_RUN(Jump, test) {
42 const Code& code = test->code(); 45 const Code& code = test->code();
43 const Instructions& instrs = Instructions::Handle(code.instructions()); 46 const Instructions& instrs = Instructions::Handle(code.instructions());
44 bool status = 47 bool status =
45 VirtualMemory::Protect(reinterpret_cast<void*>(instrs.EntryPoint()), 48 VirtualMemory::Protect(reinterpret_cast<void*>(instrs.EntryPoint()),
46 instrs.size(), 49 instrs.size(),
47 VirtualMemory::kReadWrite); 50 VirtualMemory::kReadWrite);
51 StubCode* stub_code = Isolate::Current()->stub_code();
48 EXPECT(status); 52 EXPECT(status);
49 JumpPattern jump1(test->entry(), test->code()); 53 JumpPattern jump1(test->entry(), test->code());
50 EXPECT_EQ(StubCode::InvokeDartCodeLabel().address(), 54 EXPECT_EQ(stub_code->InvokeDartCodeLabel().address(),
51 jump1.TargetAddress()); 55 jump1.TargetAddress());
52 JumpPattern jump2(test->entry() + jump1.pattern_length_in_bytes(), 56 JumpPattern jump2(test->entry() + jump1.pattern_length_in_bytes(),
53 test->code()); 57 test->code());
54 EXPECT_EQ(StubCode::AllocateArrayLabel().address(), 58 EXPECT_EQ(stub_code->AllocateArrayLabel().address(),
55 jump2.TargetAddress()); 59 jump2.TargetAddress());
56 uword target1 = jump1.TargetAddress(); 60 uword target1 = jump1.TargetAddress();
57 uword target2 = jump2.TargetAddress(); 61 uword target2 = jump2.TargetAddress();
58 jump1.SetTargetAddress(target2); 62 jump1.SetTargetAddress(target2);
59 jump2.SetTargetAddress(target1); 63 jump2.SetTargetAddress(target1);
60 EXPECT_EQ(StubCode::AllocateArrayLabel().address(), 64 EXPECT_EQ(stub_code->AllocateArrayLabel().address(),
61 jump1.TargetAddress()); 65 jump1.TargetAddress());
62 EXPECT_EQ(StubCode::InvokeDartCodeLabel().address(), 66 EXPECT_EQ(stub_code->InvokeDartCodeLabel().address(),
63 jump2.TargetAddress()); 67 jump2.TargetAddress());
64 } 68 }
65 69
66 } // namespace dart 70 } // namespace dart
67 71
68 #endif // defined TARGET_ARCH_ARM64 72 #endif // defined TARGET_ARCH_ARM64
OLDNEW
« no previous file with comments | « runtime/vm/flow_graph_compiler_x64.cc ('k') | runtime/vm/instructions_arm_test.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698