[DevTools] Allow arrow keys to increment/decrement value in numeric inputs.

[DevTools] Allow arrow keys to increment/decrement value in numeric inputs.

BUG=382234
Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=177468

[dgozman, 2014-07-02 14:16:18]

Take a look please.

[vsevik, 2014-07-02 15:17:25]

lgtm

https://codereview.chromium.org/365923002/diff/1/Source/devtools/front_end/ui...
File Source/devtools/front_end/ui/SettingsUI.js (right):

https://codereview.chromium.org/365923002/diff/1/Source/devtools/front_end/ui...
Source/devtools/front_end/ui/SettingsUI.js:150: if (validatorCallback &&
validatorCallback(value))
Looks like this is not really needed.

https://codereview.chromium.org/365923002/diff/1/Source/devtools/front_end/ui...
Source/devtools/front_end/ui/SettingsUI.js:153: if (clearForZero && !value)
So we'll never increment zero?

https://codereview.chromium.org/365923002/diff/1/Source/devtools/front_end/ui...
Source/devtools/front_end/ui/SettingsUI.js:156: if (clearForZero && !value)
Why?

[dgozman, 2014-07-02 15:50:17]

https://codereview.chromium.org/365923002/diff/1/Source/devtools/front_end/ui...
File Source/devtools/front_end/ui/SettingsUI.js (right):

https://codereview.chromium.org/365923002/diff/1/Source/devtools/front_end/ui...
Source/devtools/front_end/ui/SettingsUI.js:150: if (validatorCallback &&
validatorCallback(value))
On 2014/07/02 15:17:25, vsevik wrote:
> Looks like this is not really needed.

This is to do nothing if user enters "abc" and presses up key. Otherwise we
change to "1".

https://codereview.chromium.org/365923002/diff/1/Source/devtools/front_end/ui...
Source/devtools/front_end/ui/SettingsUI.js:153: if (clearForZero && !value)
On 2014/07/02 15:17:25, vsevik wrote:
> So we'll never increment zero?

Yes, if we replace zero value by empty string (used in responsive design view).

https://codereview.chromium.org/365923002/diff/1/Source/devtools/front_end/ui...
Source/devtools/front_end/ui/SettingsUI.js:156: if (clearForZero && !value)
On 2014/07/02 15:17:25, vsevik wrote:
> Why?

Same reasons. I don't want to switch from "1" to empty string by pressing arrow
key.

[vsevik, 2014-07-02 16:46:53]

I just thought we could keep incrementing/decrementing empty lines an any weird
values treating them as zeroes.
But I don't feel strong about it.
Do whatever you like in these cases :)

[dgozman, 2014-07-03 10:39:46]

The CQ bit was checked by dgozman@chromium.org

[commit-bot: I haz the power, 2014-07-03 10:40:52]

CQ is trying da patch. Follow status at
 https://chromium-status.appspot.com/cq/dgozman@chromium.org/365923002/1

[commit-bot: I haz the power, 2014-07-03 11:59:46]

FYI, CQ is re-trying this CL (attempt #1).
The failing builders are:
  win_blink_compile_dbg on tryserver.blink
(http://build.chromium.org/p/tryserver.blink/builders/win_blink_compile_dbg/bu...)

[commit-bot: I haz the power, 2014-07-03 12:13:38]

Change committed as 177468