Handle unresolved remote hostname for TCP sockets.

Handle unresolved remote hostname for TCP sockets.

Users of WebRTC reported that certain corporate networks that restrict the DNS resolution
to certain domains. In which case DNS resolve might fail in those conditions.

In that case proxy can resolve the addresses by using CONNECT methods.

Chrome TCP P2P sockets already handles the proxy scenarios, so by just providing the
hostname to TCP sockets should solve these problamatic scenarios.

After socket moves to a connected state, resolved address (peer address) must be reported
back to the renderer process. It's certainly needed for sending packets, but for validation
purposes its required.

BUG=https://code.google.com/p/webrtc/issues/detail?id=3384

R=sergeyu@chromium.org,jiayl@chromium.org
TBR=cevans@chromium.org
CC=juberti@chromium.org

Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=281668

[Sergey Ulanov, 2014-07-03 03:31:06]

lgtm when my nits are addressed

https://codereview.chromium.org/365903007/diff/40001/content/browser/renderer...
File content/browser/renderer_host/p2p/socket_host_tcp.cc (right):

https://codereview.chromium.org/365903007/diff/40001/content/browser/renderer...
content/browser/renderer_host/p2p/socket_host_tcp.cc:92:
remote_address.hostname, remote_address.ip_address.port());
DCHECK that hostname is not empty?

https://codereview.chromium.org/365903007/diff/40001/content/common/p2p_messa...
File content/common/p2p_messages.h (right):

https://codereview.chromium.org/365903007/diff/40001/content/common/p2p_messa...
content/common/p2p_messages.h:61: net::IPEndPoint /* socket_address */,
local_address

https://codereview.chromium.org/365903007/diff/40001/content/renderer/p2p/soc...
File content/renderer/p2p/socket_client_delegate.h (right):

https://codereview.chromium.org/365903007/diff/40001/content/renderer/p2p/soc...
content/renderer/p2p/socket_client_delegate.h:25: virtual void OnOpen(const
net::IPEndPoint& address,
rename this to local_address?

https://codereview.chromium.org/365903007/diff/40001/content/renderer/p2p/soc...
File content/renderer/p2p/socket_client_impl.cc (right):

https://codereview.chromium.org/365903007/diff/40001/content/renderer/p2p/soc...
content/renderer/p2p/socket_client_impl.cc:147: const net::IPEndPoint& address,
const net::IPEndPoint& remote_address) {
nit: one argument per line, local_address

https://codereview.chromium.org/365903007/diff/40001/content/renderer/p2p/soc...
File content/renderer/p2p/socket_dispatcher.h (right):

https://codereview.chromium.org/365903007/diff/40001/content/renderer/p2p/soc...
content/renderer/p2p/socket_dispatcher.h:97: void OnSocketCreated(int socket_id,
const net::IPEndPoint& address,
one argument per line please when all of them don't fit on one line.
local_address

[Mallinath (Gone from Chromium), 2014-07-07 17:56:45]

PTAL

https://codereview.chromium.org/365903007/diff/40001/content/browser/renderer...
File content/browser/renderer_host/p2p/socket_host_tcp.cc (right):

https://codereview.chromium.org/365903007/diff/40001/content/browser/renderer...
content/browser/renderer_host/p2p/socket_host_tcp.cc:92:
remote_address.hostname, remote_address.ip_address.port());
On 2014/07/03 03:31:06, Sergey Ulanov wrote:
> DCHECK that hostname is not empty?

Done.

https://codereview.chromium.org/365903007/diff/40001/content/common/p2p_messa...
File content/common/p2p_messages.h (right):

https://codereview.chromium.org/365903007/diff/40001/content/common/p2p_messa...
content/common/p2p_messages.h:61: net::IPEndPoint /* socket_address */,
On 2014/07/03 03:31:06, Sergey Ulanov wrote:
> local_address

Done.

https://codereview.chromium.org/365903007/diff/40001/content/renderer/p2p/soc...
File content/renderer/p2p/socket_client_delegate.h (right):

https://codereview.chromium.org/365903007/diff/40001/content/renderer/p2p/soc...
content/renderer/p2p/socket_client_delegate.h:25: virtual void OnOpen(const
net::IPEndPoint& address,
On 2014/07/03 03:31:06, Sergey Ulanov wrote:
> rename this to local_address?

Done.

https://codereview.chromium.org/365903007/diff/40001/content/renderer/p2p/soc...
File content/renderer/p2p/socket_client_impl.cc (right):

https://codereview.chromium.org/365903007/diff/40001/content/renderer/p2p/soc...
content/renderer/p2p/socket_client_impl.cc:147: const net::IPEndPoint& address,
const net::IPEndPoint& remote_address) {
On 2014/07/03 03:31:06, Sergey Ulanov wrote:
> nit: one argument per line, local_address

Done.

https://codereview.chromium.org/365903007/diff/40001/content/renderer/p2p/soc...
File content/renderer/p2p/socket_dispatcher.h (right):

https://codereview.chromium.org/365903007/diff/40001/content/renderer/p2p/soc...
content/renderer/p2p/socket_dispatcher.h:97: void OnSocketCreated(int socket_id,
const net::IPEndPoint& address,
On 2014/07/03 03:31:06, Sergey Ulanov wrote:
> one argument per line please when all of them don't fit on one line.
> local_address

Done.

[Sergey Ulanov, 2014-07-07 18:22:15]

still lgtm

[Mallinath (Gone from Chromium), 2014-07-07 22:41:53]

The CQ bit was checked by mallinath@chromium.org

[commit-bot: I haz the power, 2014-07-07 22:43:06]

CQ is trying da patch. Follow status at
 https://chromium-status.appspot.com/cq/mallinath@chromium.org/365903007/120001

[commit-bot: I haz the power, 2014-07-08 03:24:19]

FYI, CQ is re-trying this CL (attempt #1).
The failing builders are:
  android_aosp on tryserver.chromium
(http://build.chromium.org/p/tryserver.chromium/builders/android_aosp/builds/9...)
  win_chromium_rel on tryserver.chromium
(http://build.chromium.org/p/tryserver.chromium/builders/win_chromium_rel/buil...)

[commit-bot: I haz the power, 2014-07-08 05:06:32]

Change committed as 281668