Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(36)

Issue 365903006: Merge the fullscreen event queues (Closed)

Created:
6 years, 5 months ago by philipj_slow
Modified:
6 years, 5 months ago
Reviewers:
falken
CC:
blink-reviews, blink-reviews-dom_chromium.org, dglazkov+blink, sof, eae+blinkwatch, rwlbuis
Project:
blink
Visibility:
Public.

Description

Merge the fullscreen event queues The two queues are both processed by a single timer, so they might just as well be a single queue, which also avoids looping over each queue separately. Instead of queuing Nodes, Events are created and queued. This means that the event type is made explicit, which will make it simpler to support both prefixed and unprefixed events using the same code. BUG=383813 Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=177509

Patch Set 1 #

Patch Set 2 : rebase #

Patch Set 3 : introduce enqueueChangeEvent/enqueueErrorEvent #

Unified diffs Side-by-side diffs Delta from patch set Stats (+53 lines, -52 lines) Patch
M Source/core/dom/FullscreenElementStack.h View 1 2 2 chunks +6 lines, -5 lines 0 comments Download
M Source/core/dom/FullscreenElementStack.cpp View 1 2 12 chunks +47 lines, -47 lines 0 comments Download

Messages

Total messages: 7 (0 generated)
philipj_slow
PTAL. This depends on https://codereview.chromium.org/365993002/ so no try bots until that's landed, but LayoutTests/fullscreen/ tests ...
6 years, 5 months ago (2014-07-02 23:20:55 UTC) #1
philipj_slow
rebase
6 years, 5 months ago (2014-07-03 19:43:36 UTC) #2
philipj_slow
introduce enqueueChangeEvent/enqueueErrorEvent
6 years, 5 months ago (2014-07-03 20:01:16 UTC) #3
falken
On 2014/07/03 20:01:16, philipj wrote: > introduce enqueueChangeEvent/enqueueErrorEvent nice change! lgtm
6 years, 5 months ago (2014-07-04 01:42:16 UTC) #4
philipj_slow
The CQ bit was checked by philipj@opera.com
6 years, 5 months ago (2014-07-04 05:28:43 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/philipj@opera.com/365903006/40001
6 years, 5 months ago (2014-07-04 05:28:58 UTC) #6
commit-bot: I haz the power
6 years, 5 months ago (2014-07-04 05:38:47 UTC) #7
Message was sent while issue was closed.
Change committed as 177509

Powered by Google App Engine
This is Rietveld 408576698