Issue 365903005: Revert "Remove special ExecutableAccessorInfo handling based on flag"

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 365903005: Revert "Remove special ExecutableAccessorInfo handling based on flag" (Closed)

Created:
6 years, 5 months ago by Toon Verwaest

Modified:
6 years, 5 months ago

Reviewers:
dcarney

CC:
v8-dev

Base URL:
https://v8.googlecode.com/svn/branches/bleeding_edge

Project:
v8

Visibility:
Public.

More Reviews

Description

Revert "Remove special ExecutableAccessorInfo handling based on flag" Temporarily reverting until we figure out how to handle the API cases that use accessors to lazily compute values. dataAttributeGetterCustom in V8MessageEventCustom (at least) overwrites itself with the computed value using ForceSet. We can either force such clients to first use ForceDelete before caching, use some other caching mechanism; or provide an API for lazily computed properties. TBR=dcarney@chromium.org BUG= Committed: https://code.google.com/p/v8/source/detail?r=22173

Patch Set 1 #

Created: 6 years, 5 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+51 lines, -31 lines)			Patch
M	src/objects.h	View	2 chunks	+9 lines, -1 line	0 comments	Download
M	src/objects.cc	View	5 chunks	+30 lines, -23 lines	0 comments	Download
M	src/runtime.cc	View	1 chunk	+6 lines, -1 line	0 comments	Download
M	test/cctest/test-api.cc	View	1 chunk	+5 lines, -4 lines	0 comments	Download
M	test/mjsunit/es7/object-observe.js	View	1 chunk	+1 line, -2 lines	0 comments	Download

Messages

Total messages: 1 (0 generated)

Expand Messages | Collapse Messages

Toon Verwaest

6 years, 5 months ago (2014-07-02 16:59:15 UTC) #1

Message was sent while issue was closed.

Committed patchset #1 manually as r22173 (presubmit successful).

Expand Messages | Collapse Messages