Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(185)

Issue 365863003: Reland^2 r22105 "Remove static initializer from isolate" (Closed)

Created:
6 years, 5 months ago by jochen (gone - plz use gerrit)
Modified:
6 years, 5 months ago
Reviewers:
dcarney
CC:
v8-dev
Project:
v8
Visibility:
Public.

Description

Reland^2 r22105 "Remove static initializer from isolate" Make Isolate::UncheckedCurrent() return NULL if Isolate wasn't yet initialized to avoid reentrancy when running with the profiler BUG=none R=dcarney@chromium.org LOG=n Committed: https://code.google.com/p/v8/source/detail?r=22167

Patch Set 1 #

Patch Set 2 : updates #

Unified diffs Side-by-side diffs Delta from patch set Stats (+30 lines, -41 lines) Patch
M src/isolate.h View 1 6 chunks +18 lines, -8 lines 0 comments Download
M src/isolate.cc View 1 6 chunks +10 lines, -28 lines 0 comments Download
M src/mksnapshot.cc View 1 chunk +0 lines, -1 line 0 comments Download
M src/sampler.cc View 1 1 chunk +1 line, -1 line 0 comments Download
M test/cctest/cctest.cc View 1 chunk +0 lines, -1 line 0 comments Download
M tools/check-static-initializers.sh View 1 chunk +1 line, -2 lines 0 comments Download

Messages

Total messages: 3 (0 generated)
jochen (gone - plz use gerrit)
6 years, 5 months ago (2014-07-02 09:22:48 UTC) #1
dcarney
lgtm
6 years, 5 months ago (2014-07-02 09:34:32 UTC) #2
jochen (gone - plz use gerrit)
6 years, 5 months ago (2014-07-02 14:44:02 UTC) #3
Message was sent while issue was closed.
Committed patchset #2 manually as r22167 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698