Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(481)

Issue 365823004: Add LIBMTP_Get_Children() to read the list of raw IDs of a folder. (Closed)

Created:
6 years, 5 months ago by kinaba
Modified:
6 years, 5 months ago
Reviewers:
Lei Zhang
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/deps/libmtp.git@master
Visibility:
Public.

Description

Add LIBMTP_Get_Children() to read the list of raw IDs of a folder. BUG=385307 R=thestig@chromium.org Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=284892

Patch Set 1 #

Total comments: 4

Patch Set 2 : Addressed review comments (#1) #

Patch Set 3 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+206 lines, -0 lines) Patch
A patches/19_raw_read_directory.patch View 1 1 chunk +125 lines, -0 lines 0 comments Download
M src/libmtp.h View 1 1 chunk +4 lines, -0 lines 0 comments Download
M src/libmtp.c View 1 1 chunk +72 lines, -0 lines 0 comments Download
M src/libmtp.sym View 1 chunk +1 line, -0 lines 0 comments Download
M src/libmtp.h.in View 1 chunk +4 lines, -0 lines 0 comments Download

Messages

Total messages: 4 (0 generated)
Lei Zhang
lgtm with some nits. Please update the .patch file too. https://codereview.chromium.org/365823004/diff/1/src/libmtp.c File src/libmtp.c (right): https://codereview.chromium.org/365823004/diff/1/src/libmtp.c#newcode4430 ...
6 years, 5 months ago (2014-07-23 08:39:30 UTC) #1
kinaba
https://codereview.chromium.org/365823004/diff/1/src/libmtp.c File src/libmtp.c (right): https://codereview.chromium.org/365823004/diff/1/src/libmtp.c#newcode4436 src/libmtp.c:4436: uint32_t** out) On 2014/07/23 08:39:30, Lei Zhang wrote: > ...
6 years, 5 months ago (2014-07-23 08:59:53 UTC) #2
kinaba
https://codereview.chromium.org/365823004/diff/1/src/libmtp.c File src/libmtp.c (right): https://codereview.chromium.org/365823004/diff/1/src/libmtp.c#newcode4430 src/libmtp.c:4430: * @param out the pointer where the array of ...
6 years, 5 months ago (2014-07-23 09:00:11 UTC) #3
kinaba
6 years, 5 months ago (2014-07-23 09:24:11 UTC) #4
Message was sent while issue was closed.
Committed patchset #3 manually as r284892 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698