components/autofill/core/browser/autofill_metrics_unittest.cc - Issue 365783002: Autofill: don't require POST method.

Unified Diff: components/autofill/core/browser/autofill_metrics_unittest.cc

Issue 365783002: Autofill: don't require POST method. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: remove method_ member Created 6 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

« no previous file with comments | « components/autofill/core/browser/autofill_merge_unittest.cc ('k') | components/autofill/core/browser/autofill_test_utils.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: components/autofill/core/browser/autofill_metrics_unittest.cc

diff --git a/components/autofill/core/browser/autofill_metrics_unittest.cc b/components/autofill/core/browser/autofill_metrics_unittest.cc

index 14f3d2cd079ade832738dad5e3da9f70211abec6..926542b89e3eb3d5abb6c44dbc126faa96ef10a7 100644

--- a/components/autofill/core/browser/autofill_metrics_unittest.cc

+++ b/components/autofill/core/browser/autofill_metrics_unittest.cc

@@ -283,7 +283,6 @@ TEST_F(AutofillMetricsTest, QualityMetrics) {

// Set up our form data.

FormData form;

form.name = ASCIIToUTF16("TestForm");

- form.method = ASCIIToUTF16("POST");

form.origin = GURL("http://example.com/form.html");

form.action = GURL("http://example.com/submit.html");

form.user_submitted = true;

@@ -391,7 +390,6 @@ TEST_F(AutofillMetricsTest, SaneMetricsWithCacheMismatch) {

// Set up our form data.

FormData form;

form.name = ASCIIToUTF16("TestForm");

- form.method = ASCIIToUTF16("POST");

form.origin = GURL("http://example.com/form.html");

form.action = GURL("http://example.com/submit.html");

form.user_submitted = true;

@@ -493,7 +491,6 @@ TEST_F(AutofillMetricsTest, DeveloperEngagement) {

// Start with a non-fillable form.

FormData form;

form.name = ASCIIToUTF16("TestForm");

- form.method = ASCIIToUTF16("POST");

form.origin = GURL("http://example.com/form.html");

form.action = GURL("http://example.com/submit.html");

@@ -602,7 +599,6 @@ TEST_F(AutofillMetricsTest, AddressSuggestionsCount) {

// Set up our form data.

FormData form;

form.name = ASCIIToUTF16("TestForm");

- form.method = ASCIIToUTF16("POST");

form.origin = GURL("http://example.com/form.html");

form.action = GURL("http://example.com/submit.html");

form.user_submitted = true;

@@ -691,7 +687,6 @@ TEST_F(AutofillMetricsTest, UserHappinessFormLoadAndSubmission) {

// Start with a form with insufficiently many fields.

FormData form;

form.name = ASCIIToUTF16("TestForm");

- form.method = ASCIIToUTF16("POST");

form.origin = GURL("http://example.com/form.html");

form.action = GURL("http://example.com/submit.html");

form.user_submitted = true;

@@ -825,7 +820,6 @@ TEST_F(AutofillMetricsTest, UserHappinessFormInteraction) {

// Load a fillable form.

FormData form;

form.name = ASCIIToUTF16("TestForm");

- form.method = ASCIIToUTF16("POST");

form.origin = GURL("http://example.com/form.html");

form.action = GURL("http://example.com/submit.html");

form.user_submitted = true;

@@ -932,7 +926,6 @@ TEST_F(AutofillMetricsTest, FormFillDuration) {

// Load a fillable form.

FormData form;

form.name = ASCIIToUTF16("TestForm");

- form.method = ASCIIToUTF16("POST");

form.origin = GURL("http://example.com/form.html");

form.action = GURL("http://example.com/submit.html");

form.user_submitted = true;