Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(279)

Issue 36573003: Add UseCounters for Element.webkitRequestFullscreen/webkitRequestFullScreen (Closed)

Created:
7 years, 2 months ago by philipj_slow
Modified:
7 years, 2 months ago
CC:
blink-reviews, dglazkov+blink, eae+blinkwatch, Inactive, adamk+blink_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/blink.git@master
Visibility:
Public.

Description

Add UseCounters for Element.webkitRequestFullscreen/webkitRequestFullScreen Spawned from "Is there a plan for shipping unprefixed fullscreen API?" https://groups.google.com/a/chromium.org/d/msg/blink-dev/iElkfxDU7d4/gV0HS8guXscJ BUG=none Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=160329

Patch Set 1 #

Total comments: 2
Unified diffs Side-by-side diffs Delta from patch set Stats (+4 lines, -2 lines) Patch
M Source/core/dom/Element.idl View 1 chunk +2 lines, -2 lines 0 comments Download
M Source/core/page/UseCounter.h View 1 chunk +2 lines, -0 lines 2 comments Download

Messages

Total messages: 6 (0 generated)
philipj_slow
7 years, 2 months ago (2013-10-23 07:45:00 UTC) #1
jochen (gone - plz use gerrit)
https://codereview.chromium.org/36573003/diff/1/Source/core/page/UseCounter.h File Source/core/page/UseCounter.h (right): https://codereview.chromium.org/36573003/diff/1/Source/core/page/UseCounter.h#newcode238 Source/core/page/UseCounter.h:238: PrefixedElementRequestFullscreen, maybe we should add Mozilla and W3C suffixes ...
7 years, 2 months ago (2013-10-23 09:37:02 UTC) #2
philipj_slow
https://codereview.chromium.org/36573003/diff/1/Source/core/page/UseCounter.h File Source/core/page/UseCounter.h (right): https://codereview.chromium.org/36573003/diff/1/Source/core/page/UseCounter.h#newcode238 Source/core/page/UseCounter.h:238: PrefixedElementRequestFullscreen, On 2013/10/23 09:37:03, jochen wrote: > maybe we ...
7 years, 2 months ago (2013-10-23 09:41:31 UTC) #3
jochen (gone - plz use gerrit)
On 2013/10/23 09:41:31, philipj wrote: > https://codereview.chromium.org/36573003/diff/1/Source/core/page/UseCounter.h > File Source/core/page/UseCounter.h (right): > > https://codereview.chromium.org/36573003/diff/1/Source/core/page/UseCounter.h#newcode238 > ...
7 years, 2 months ago (2013-10-23 09:44:27 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/philipj@opera.com/36573003/1
7 years, 2 months ago (2013-10-23 09:49:43 UTC) #5
commit-bot: I haz the power
7 years, 2 months ago (2013-10-23 10:47:39 UTC) #6
Message was sent while issue was closed.
Change committed as 160329

Powered by Google App Engine
This is Rietveld 408576698