CTFontCopy*Name may return NULL.

CTFontCopy*Name may return NULL.

BUG=skia:2708
Committed: https://skia.googlesource.com/skia/+/256b351fb1d33f3e3156d090a6a533b54ad66117

[reed1, 2014-07-01 18:46:23]

https://codereview.chromium.org/365683004/diff/1/src/ports/SkFontHost_mac.cpp
File src/ports/SkFontHost_mac.cpp (right):

https://codereview.chromium.org/365683004/diff/1/src/ports/SkFontHost_mac.cpp...
src/ports/SkFontHost_mac.cpp:1903: static const char* get_str(CFStringRef ref,
SkString* str) {
does our caller (in this file) know to look for NULL, or should we instead
return "" ?

[bungeman-skia, 2014-07-01 18:48:21]

On 2014/07/01 18:46:23, reed1 wrote:
> https://codereview.chromium.org/365683004/diff/1/src/ports/SkFontHost_mac.cpp
> File src/ports/SkFontHost_mac.cpp (right):
> 
>
https://codereview.chromium.org/365683004/diff/1/src/ports/SkFontHost_mac.cpp...
> src/ports/SkFontHost_mac.cpp:1903: static const char* get_str(CFStringRef ref,
> SkString* str) {
> does our caller (in this file) know to look for NULL, or should we instead
> return "" ?

We should return NULL. It does the right thing.

[caryclark, 2014-07-02 14:40:55]

lgtm (sorry about not getting to this sooner)

[bungeman-skia, 2014-07-02 14:42:13]

The CQ bit was checked by bungeman@google.com

[commit-bot: I haz the power, 2014-07-02 14:42:57]

CQ is trying da patch. Follow status at
 https://skia-tree-status.appspot.com/cq/bungeman@google.com/365683004/1

[commit-bot: I haz the power, 2014-07-02 14:58:05]

Change committed as 256b351fb1d33f3e3156d090a6a533b54ad66117