Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(25)

Unified Diff: Source/core/html/canvas/CanvasGradient.h

Issue 365653002: Oilpan: move 2D Canvas and WebGL objects to the heap. (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master
Patch Set: Round of improvements Created 6 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: Source/core/html/canvas/CanvasGradient.h
diff --git a/Source/core/html/canvas/CanvasGradient.h b/Source/core/html/canvas/CanvasGradient.h
index fb1181cadcc78f60edb31f32ba2a9986fc509a77..e723542545fc8664688bce735bf5008a6236b921 100644
--- a/Source/core/html/canvas/CanvasGradient.h
+++ b/Source/core/html/canvas/CanvasGradient.h
@@ -29,6 +29,7 @@
#include "bindings/core/v8/ScriptWrappable.h"
#include "platform/graphics/Gradient.h"
+#include "platform/heap/Handle.h"
#include "wtf/Forward.h"
#include "wtf/PassRefPtr.h"
#include "wtf/RefCounted.h"
@@ -37,21 +38,23 @@ namespace WebCore {
class ExceptionState;
-class CanvasGradient : public RefCounted<CanvasGradient>, public ScriptWrappable {
+class CanvasGradient FINAL : public RefCountedWillBeGarbageCollectedFinalized<CanvasGradient>, public ScriptWrappable {
public:
- static PassRefPtr<CanvasGradient> create(const FloatPoint& p0, const FloatPoint& p1)
+ static PassRefPtrWillBeRawPtr<CanvasGradient> create(const FloatPoint& p0, const FloatPoint& p1)
{
- return adoptRef(new CanvasGradient(p0, p1));
+ return adoptRefWillBeNoop(new CanvasGradient(p0, p1));
}
- static PassRefPtr<CanvasGradient> create(const FloatPoint& p0, float r0, const FloatPoint& p1, float r1)
+ static PassRefPtrWillBeRawPtr<CanvasGradient> create(const FloatPoint& p0, float r0, const FloatPoint& p1, float r1)
{
- return adoptRef(new CanvasGradient(p0, r0, p1, r1));
+ return adoptRefWillBeNoop(new CanvasGradient(p0, r0, p1, r1));
}
Gradient* gradient() const { return m_gradient.get(); }
void addColorStop(float value, const String& color, ExceptionState&);
+ void trace(Visitor*) { }
+
private:
CanvasGradient(const FloatPoint& p0, const FloatPoint& p1);
CanvasGradient(const FloatPoint& p0, float r0, const FloatPoint& p1, float r1);

Powered by Google App Engine
This is Rietveld 408576698