Chromium Code Reviews

Unified Diff: Source/bindings/core/v8/custom/V8WebGLRenderingContextCustom.cpp

Issue 365653002: Oilpan: move 2D Canvas and WebGL objects to the heap. (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master
Patch Set: Round of improvements Created 6 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments.
Jump to:
View side-by-side diff with in-line comments
Index: Source/bindings/core/v8/custom/V8WebGLRenderingContextCustom.cpp
diff --git a/Source/bindings/core/v8/custom/V8WebGLRenderingContextCustom.cpp b/Source/bindings/core/v8/custom/V8WebGLRenderingContextCustom.cpp
index 9e1ad2505812db8d42faaacbe87add92f1ed81e9..1e3b2712e81dfe147d01e16dc366d3e1f10be3b5 100644
--- a/Source/bindings/core/v8/custom/V8WebGLRenderingContextCustom.cpp
+++ b/Source/bindings/core/v8/custom/V8WebGLRenderingContextCustom.cpp
@@ -346,7 +346,7 @@ void V8WebGLRenderingContext::getAttachedShadersMethodCustom(const v8::FunctionC
return;
}
WebGLProgram* program = V8WebGLProgram::toNativeWithTypeCheck(info.GetIsolate(), info[programArgumentIndex]);
- Vector<RefPtr<WebGLShader> > shaders;
+ WillBeHeapVector<RefPtrWillBeMember<WebGLShader> > shaders;
bool succeed = context->getAttachedShaders(program, shaders);
if (!succeed) {
v8SetReturnValueNull(info);
@@ -374,7 +374,7 @@ void V8WebGLRenderingContext::getExtensionMethodCustom(const v8::FunctionCallbac
return;
}
TOSTRING_VOID(V8StringResource<>, name, info[0]);
- RefPtr<WebGLExtension> extension(impl->getExtension(name));
+ RefPtrWillBeRawPtr<WebGLExtension> extension(impl->getExtension(name));
v8SetReturnValue(info, toV8Object(extension.get(), info.Holder(), info.GetIsolate()));
}

Powered by Google App Engine