Source/core/html/canvas/WebGLDrawBuffers.h - Issue 365653002: Oilpan: move 2D Canvas and WebGL objects to the heap.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: Source/core/html/canvas/WebGLDrawBuffers.h

Issue 365653002: Oilpan: move 2D Canvas and WebGL objects to the heap. (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master

Patch Set: Review-induced improvements + rebase Created 6 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« Source/core/html/canvas/WebGLContextObject.cpp ('K') | « Source/core/html/canvas/WebGLDepthTexture.idl ('k') | Source/core/html/canvas/WebGLDrawBuffers.cpp » ('j') | Source/core/html/canvas/WebGLObject.cpp » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: Source/core/html/canvas/WebGLDrawBuffers.h

diff --git a/Source/core/html/canvas/WebGLDrawBuffers.h b/Source/core/html/canvas/WebGLDrawBuffers.h

index 11c5254270ae61a2b9113e9816994ccb85a1a9b3..dc1546163d61d861d1dce2f0e643dd14d240f710 100644

--- a/Source/core/html/canvas/WebGLDrawBuffers.h

+++ b/Source/core/html/canvas/WebGLDrawBuffers.h

@@ -34,7 +34,7 @@ namespace blink {

class WebGLDrawBuffers FINAL : public WebGLExtension, public ScriptWrappable {

public:

- static PassRefPtr<WebGLDrawBuffers> create(WebGLRenderingContextBase*);

+ static PassRefPtrWillBeRawPtr<WebGLDrawBuffers> create(WebGLRenderingContextBase*);

static bool supported(WebGLRenderingContextBase*);

static const char* extensionName();

@@ -44,7 +44,7 @@ public:

void drawBuffersWEBGL(const Vector<GLenum>& buffers);

private:

- WebGLDrawBuffers(WebGLRenderingContextBase*);

+ explicit WebGLDrawBuffers(WebGLRenderingContextBase*);

static bool satisfiesWebGLRequirements(WebGLRenderingContextBase*);

};