Source/bindings/core/v8/custom/V8HTMLCanvasElementCustom.cpp - Issue 365653002: Oilpan: move 2D Canvas and WebGL objects to the heap.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: Source/bindings/core/v8/custom/V8HTMLCanvasElementCustom.cpp

Issue 365653002: Oilpan: move 2D Canvas and WebGL objects to the heap. (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master

Patch Set: Review-induced improvements + rebase Created 6 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « Source/bindings/core/v8/custom/V8CanvasRenderingContext2DCustom.cpp ('k') | Source/bindings/core/v8/custom/V8WebGLRenderingContextCustom.cpp » ('j') | Source/core/html/canvas/CanvasRenderingContext2D.cpp » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: Source/bindings/core/v8/custom/V8HTMLCanvasElementCustom.cpp

diff --git a/Source/bindings/core/v8/custom/V8HTMLCanvasElementCustom.cpp b/Source/bindings/core/v8/custom/V8HTMLCanvasElementCustom.cpp

index 6710887dfb97b3934a4dae603d9c791cbf64bd91..2c75a5db6ac22647d50f1dbecd8861f438192c9f 100644

--- a/Source/bindings/core/v8/custom/V8HTMLCanvasElementCustom.cpp

+++ b/Source/bindings/core/v8/custom/V8HTMLCanvasElementCustom.cpp

@@ -54,9 +54,9 @@ void V8HTMLCanvasElement::getContextMethodCustom(const v8::FunctionCallbackInfo<

HTMLCanvasElement* impl = V8HTMLCanvasElement::toNative(holder);

TOSTRING_VOID(V8StringResource<>, contextIdResource, info[0]);

String contextId = contextIdResource;

- RefPtr<CanvasContextAttributes> attributes;

+ RefPtrWillBeRawPtr<CanvasContextAttributes> attributes = nullptr;

if (contextId == "webgl" || contextId == "experimental-webgl") {

- RefPtr<WebGLContextAttributes> webGLAttributes = WebGLContextAttributes::create();

+ RefPtrWillBeRawPtr<WebGLContextAttributes> webGLAttributes = WebGLContextAttributes::create();

if (info.Length() > 1 && info[1]->IsObject()) {

v8::Handle<v8::Object> jsAttributes = info[1]->ToObject();

v8::Handle<v8::String> alpha = v8AtomicString(isolate, "alpha");

@@ -83,7 +83,7 @@ void V8HTMLCanvasElement::getContextMethodCustom(const v8::FunctionCallbackInfo<

}

attributes = webGLAttributes;

} else {

- RefPtr<Canvas2DContextAttributes> canvas2DAttributes = Canvas2DContextAttributes::create();

+ RefPtrWillBeRawPtr<Canvas2DContextAttributes> canvas2DAttributes = Canvas2DContextAttributes::create();

if (info.Length() > 1 && info[1]->IsObject()) {

v8::Handle<v8::Object> jsAttributes = info[1]->ToObject();

v8::Handle<v8::String> alpha = v8AtomicString(isolate, "alpha");