Chromium Code Reviews| Index: Source/core/html/canvas/WebGLRenderbuffer.cpp |
| diff --git a/Source/core/html/canvas/WebGLRenderbuffer.cpp b/Source/core/html/canvas/WebGLRenderbuffer.cpp |
| index 76ef482e03748f2fe2614097112908290575c4b6..bc22b1b5440c25357545584b206ea401fe80ca55 100644 |
| --- a/Source/core/html/canvas/WebGLRenderbuffer.cpp |
| +++ b/Source/core/html/canvas/WebGLRenderbuffer.cpp |
| @@ -31,14 +31,18 @@ |
| namespace WebCore { |
| -PassRefPtr<WebGLRenderbuffer> WebGLRenderbuffer::create(WebGLRenderingContextBase* ctx) |
| +PassRefPtrWillBeRawPtr<WebGLRenderbuffer> WebGLRenderbuffer::create(WebGLRenderingContextBase* ctx) |
| { |
| - return adoptRef(new WebGLRenderbuffer(ctx)); |
| + return adoptRefWillBeNoop(new WebGLRenderbuffer(ctx)); |
| } |
| WebGLRenderbuffer::~WebGLRenderbuffer() |
| { |
| - deleteObject(0); |
| +#if ENABLE(OILPAN) |
| + // This render buffer (heap) object must finalize itself. |
| + m_emulatedStencilBuffer.clear(); |
| +#endif |
| + detachAndDeleteObject(); |
|
Ken Russell (switch to Gerrit)
2014/07/19 00:27:15
Please document the need to manually call detach()
sof
2014/07/19 19:55:57
Added
|
| } |
| WebGLRenderbuffer::WebGLRenderbuffer(WebGLRenderingContextBase* ctx) |
| @@ -66,4 +70,10 @@ void WebGLRenderbuffer::deleteEmulatedStencilBuffer(blink::WebGraphicsContext3D* |
| m_emulatedStencilBuffer.clear(); |
| } |
| +void WebGLRenderbuffer::trace(Visitor* visitor) |
| +{ |
| + visitor->trace(m_emulatedStencilBuffer); |
| + WebGLSharedObject::trace(visitor); |
| +} |
| + |
| } |