Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(13)

Unified Diff: Source/core/html/canvas/WebGLProgram.h

Issue 365653002: Oilpan: move 2D Canvas and WebGL objects to the heap. (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master
Patch Set: Have Nullable<T>::trace() use TraceIfNeeded<>. Created 6 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: Source/core/html/canvas/WebGLProgram.h
diff --git a/Source/core/html/canvas/WebGLProgram.h b/Source/core/html/canvas/WebGLProgram.h
index 808b834b8d651e94fcfffbe6139d1a2d1b96214d..5240b11d72b39fe2a8e0dff555dc4b26aba8b5d4 100644
--- a/Source/core/html/canvas/WebGLProgram.h
+++ b/Source/core/html/canvas/WebGLProgram.h
@@ -38,7 +38,7 @@ class WebGLProgram FINAL : public WebGLSharedObject, public ScriptWrappable {
public:
virtual ~WebGLProgram();
- static PassRefPtr<WebGLProgram> create(WebGLRenderingContextBase*);
+ static PassRefPtrWillBeRawPtr<WebGLProgram> create(WebGLRenderingContextBase*);
unsigned numActiveAttribLocations();
GLint getActiveAttribLocation(GLuint index);
@@ -59,8 +59,10 @@ public:
bool attachShader(WebGLShader*);
bool detachShader(WebGLShader*);
+ virtual void trace(Visitor*) OVERRIDE;
+
protected:
- WebGLProgram(WebGLRenderingContextBase*);
+ explicit WebGLProgram(WebGLRenderingContextBase*);
virtual void deleteObjectImpl(blink::WebGraphicsContext3D*, Platform3DObject) OVERRIDE;
@@ -78,8 +80,8 @@ private:
// program or not.
unsigned m_linkCount;
- RefPtr<WebGLShader> m_vertexShader;
- RefPtr<WebGLShader> m_fragmentShader;
+ RefPtrWillBeMember<WebGLShader> m_vertexShader;
+ RefPtrWillBeMember<WebGLShader> m_fragmentShader;
bool m_infoValid;
};

Powered by Google App Engine
This is Rietveld 408576698