Source/core/html/canvas/WebGLProgram.h - Issue 365653002: Oilpan: move 2D Canvas and WebGL objects to the heap.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: Source/core/html/canvas/WebGLProgram.h

Issue 365653002: Oilpan: move 2D Canvas and WebGL objects to the heap. (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master

Patch Set: Rebase Created 6 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« Source/core/html/canvas/WebGLExtension.h ('K') | « Source/core/html/canvas/WebGLObject.cpp ('k') | Source/core/html/canvas/WebGLProgram.cpp » ('j') | Source/core/html/canvas/WebGLSharedObject.cpp » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: Source/core/html/canvas/WebGLProgram.h

diff --git a/Source/core/html/canvas/WebGLProgram.h b/Source/core/html/canvas/WebGLProgram.h

index 808b834b8d651e94fcfffbe6139d1a2d1b96214d..66c7e3c3b5d67b1d5f65a9c51015ee348051c17d 100644

--- a/Source/core/html/canvas/WebGLProgram.h

+++ b/Source/core/html/canvas/WebGLProgram.h

@@ -38,7 +38,7 @@ class WebGLProgram FINAL : public WebGLSharedObject, public ScriptWrappable {

public:

virtual ~WebGLProgram();

- static PassRefPtr<WebGLProgram> create(WebGLRenderingContextBase*);

+ static PassRefPtrWillBeRawPtr<WebGLProgram> create(WebGLRenderingContextBase*);

unsigned numActiveAttribLocations();

GLint getActiveAttribLocation(GLuint index);

@@ -59,6 +59,8 @@ public:

bool attachShader(WebGLShader*);

bool detachShader(WebGLShader*);

+ virtual void trace(Visitor*) OVERRIDE;

protected:

WebGLProgram(WebGLRenderingContextBase*);

@@ -78,8 +80,8 @@ private:

// program or not.

unsigned m_linkCount;

- RefPtr<WebGLShader> m_vertexShader;

- RefPtr<WebGLShader> m_fragmentShader;

+ RefPtrWillBeMember<WebGLShader> m_vertexShader;

+ RefPtrWillBeMember<WebGLShader> m_fragmentShader;

bool m_infoValid;

};