Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(148)

Unified Diff: Source/bindings/core/v8/Nullable.h

Issue 365653002: Oilpan: move 2D Canvas and WebGL objects to the heap. (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master
Patch Set: Rebased + Nullable<traceable-value> workaround Created 6 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: Source/bindings/core/v8/Nullable.h
diff --git a/Source/bindings/core/v8/Nullable.h b/Source/bindings/core/v8/Nullable.h
index 0f8356c472d399a03fad26c4fcbcda01f3f8ce64..576c0e3ac6f061b568f67d647807080268f5729f 100644
--- a/Source/bindings/core/v8/Nullable.h
+++ b/Source/bindings/core/v8/Nullable.h
@@ -5,12 +5,14 @@
#ifndef Nullable_h
#define Nullable_h
+#include "platform/heap/Handle.h"
#include "wtf/Assertions.h"
namespace WebCore {
template <typename T>
class Nullable {
+ DISALLOW_ALLOCATION();
public:
Nullable()
: m_value()
@@ -41,6 +43,12 @@ public:
return (m_isNull && other.m_isNull) || (!m_isNull && !other.m_isNull && m_value == other.m_value);
}
+ void trace(Visitor*)
+ {
+ // FIXME: candidate for EnableIf<> and NeedsTracing<>, somehow ?
sof 2014/07/12 07:22:09 When rebasing past r177935's addition of Nullable<
+ (void)m_value;
+ }
+
private:
T m_value;
bool m_isNull;
« no previous file with comments | « Source/bindings/core/v8/Dictionary.cpp ('k') | Source/bindings/core/v8/custom/V8CanvasRenderingContext2DCustom.cpp » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698