Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(967)

Unified Diff: Source/core/html/canvas/WebGLShader.cpp

Issue 365653002: Oilpan: move 2D Canvas and WebGL objects to the heap. (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master
Patch Set: Make WebGLObjects keep a blink::WebGraphicsContext3D for finalization. Created 6 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: Source/core/html/canvas/WebGLShader.cpp
diff --git a/Source/core/html/canvas/WebGLShader.cpp b/Source/core/html/canvas/WebGLShader.cpp
index 203041e85cf66c225b4cb8e2693f455b89f450e8..bf87f2fd08ab04031992455dd500d10758f16a2e 100644
--- a/Source/core/html/canvas/WebGLShader.cpp
+++ b/Source/core/html/canvas/WebGLShader.cpp
@@ -31,9 +31,9 @@
namespace WebCore {
-PassRefPtr<WebGLShader> WebGLShader::create(WebGLRenderingContextBase* ctx, GLenum type)
+PassRefPtrWillBeRawPtr<WebGLShader> WebGLShader::create(WebGLRenderingContextBase* ctx, GLenum type)
{
- return adoptRef(new WebGLShader(ctx, type));
+ return adoptRefWillBeNoop(new WebGLShader(ctx, type));
}
WebGLShader::WebGLShader(WebGLRenderingContextBase* ctx, GLenum type)
@@ -47,6 +47,7 @@ WebGLShader::WebGLShader(WebGLRenderingContextBase* ctx, GLenum type)
WebGLShader::~WebGLShader()
{
+ detach();
deleteObject(0);
}

Powered by Google App Engine
This is Rietveld 408576698