Source/bindings/core/v8/custom/V8WebGLRenderingContextCustom.cpp - Issue 365653002: Oilpan: move 2D Canvas and WebGL objects to the heap.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: Source/bindings/core/v8/custom/V8WebGLRenderingContextCustom.cpp

Issue 365653002: Oilpan: move 2D Canvas and WebGL objects to the heap. (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master

Patch Set: Make WebGLObjects keep a blink::WebGraphicsContext3D for finalization. Created 6 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « Source/bindings/core/v8/custom/V8HTMLCanvasElementCustom.cpp ('k') | Source/core/html/TextMetrics.h » ('j') | Source/core/html/canvas/CanvasRenderingContext2D.cpp » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: Source/bindings/core/v8/custom/V8WebGLRenderingContextCustom.cpp

diff --git a/Source/bindings/core/v8/custom/V8WebGLRenderingContextCustom.cpp b/Source/bindings/core/v8/custom/V8WebGLRenderingContextCustom.cpp

index 9e1ad2505812db8d42faaacbe87add92f1ed81e9..1e3b2712e81dfe147d01e16dc366d3e1f10be3b5 100644

--- a/Source/bindings/core/v8/custom/V8WebGLRenderingContextCustom.cpp

+++ b/Source/bindings/core/v8/custom/V8WebGLRenderingContextCustom.cpp

@@ -346,7 +346,7 @@ void V8WebGLRenderingContext::getAttachedShadersMethodCustom(const v8::FunctionC

return;

}

WebGLProgram* program = V8WebGLProgram::toNativeWithTypeCheck(info.GetIsolate(), info[programArgumentIndex]);

- Vector<RefPtr<WebGLShader> > shaders;

+ WillBeHeapVector<RefPtrWillBeMember<WebGLShader> > shaders;

bool succeed = context->getAttachedShaders(program, shaders);

if (!succeed) {

v8SetReturnValueNull(info);

@@ -374,7 +374,7 @@ void V8WebGLRenderingContext::getExtensionMethodCustom(const v8::FunctionCallbac

return;

}

TOSTRING_VOID(V8StringResource<>, name, info[0]);

- RefPtr<WebGLExtension> extension(impl->getExtension(name));

+ RefPtrWillBeRawPtr<WebGLExtension> extension(impl->getExtension(name));

v8SetReturnValue(info, toV8Object(extension.get(), info.Holder(), info.GetIsolate()));

}