Source/bindings/core/v8/Dictionary.cpp - Issue 365653002: Oilpan: move 2D Canvas and WebGL objects to the heap.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: Source/bindings/core/v8/Dictionary.cpp

Issue 365653002: Oilpan: move 2D Canvas and WebGL objects to the heap. (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master

Patch Set: Make WebGLObjects keep a blink::WebGraphicsContext3D for finalization. Created 6 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « Source/bindings/core/v8/Dictionary.h ('k') | Source/bindings/core/v8/custom/V8CanvasRenderingContext2DCustom.cpp » ('j') | Source/core/html/canvas/CanvasRenderingContext2D.cpp » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: Source/bindings/core/v8/Dictionary.cpp

diff --git a/Source/bindings/core/v8/Dictionary.cpp b/Source/bindings/core/v8/Dictionary.cpp

index 04ff2ebe761ecde9f5d97300825dba3d53e26c58..386e0f8f51bd92c835c248049a7f66c1e56315cf 100644

--- a/Source/bindings/core/v8/Dictionary.cpp

+++ b/Source/bindings/core/v8/Dictionary.cpp

@@ -436,7 +436,7 @@ bool Dictionary::getWithUndefinedOrNullCheck(const String& key, RefPtrWillBeMemb

return true;

}

-bool Dictionary::getWithUndefinedOrNullCheck(const String& key, RefPtr<Path2D>& value) const

+bool Dictionary::getWithUndefinedOrNullCheck(const String& key, RefPtrWillBeMember<Path2D>& value) const

{

v8::Local<v8::Value> v8Value;

if (!getKey(key, v8Value) || WebCore::isUndefinedOrNull(v8Value))