Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(33)

Issue 365583003: [fsp] Remove weak pointers from loggers wherever possible. (Closed)

Created:
6 years, 5 months ago by mtomasz
Modified:
6 years, 5 months ago
Reviewers:
hashimoto
CC:
chromium-reviews, stevenjb+watch_chromium.org, davemoore+watch_chromium.org, oshima+watch_chromium.org, nkostylev+watch_chromium.org
Project:
chromium
Visibility:
Public.

Description

[fsp] Remove weak pointers from loggers wherever possible. Crashing is better than ignoring an unexpected callback call. This patch removes weak pointers from loggers, which used to prevent catching such bugs. TEST=unit_test: *FileSystemProvider* BUG=248427 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=281009

Patch Set 1 #

Messages

Total messages: 6 (0 generated)
mtomasz
@hashimoto: PTAL. Thanks.
6 years, 5 months ago (2014-07-01 10:07:58 UTC) #1
hashimoto
lgtm
6 years, 5 months ago (2014-07-02 09:01:23 UTC) #2
mtomasz
The CQ bit was checked by mtomasz@chromium.org
6 years, 5 months ago (2014-07-02 09:52:33 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/mtomasz@chromium.org/365583003/1
6 years, 5 months ago (2014-07-02 09:54:01 UTC) #4
commit-bot: I haz the power
FYI, CQ is re-trying this CL (attempt #1). The failing builders are: win_chromium_rel on tryserver.chromium ...
6 years, 5 months ago (2014-07-02 10:40:50 UTC) #5
commit-bot: I haz the power
6 years, 5 months ago (2014-07-02 12:52:01 UTC) #6
Message was sent while issue was closed.
Change committed as 281009

Powered by Google App Engine
This is Rietveld 408576698